KEMBAR78
[CMake] fix cmake regex to match newly introduced 9.0a architecture by youkaichao · Pull Request #123243 · pytorch/pytorch · GitHub
Skip to content

Conversation

@youkaichao
Copy link
Collaborator

When people build pytorch extensions with cmake, and the GPU supports 9.0a arch as introduced in #110587 , the cmake regex is not updated to recognize the change, leading to cmake breaks like #113948 and #119946 .

This PR should fix them.

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123243

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit fb8cd2d with merge base 9288b27 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bdhirsh bdhirsh requested a review from malfet April 3, 2024 20:02
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 3, 2024
@malfet
Copy link
Contributor

malfet commented Apr 3, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 3, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@youkaichao
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@youkaichao
Copy link
Collaborator Author

@malfet I think this should go into 2.3 release, otherwise it breaks pytorch cmake users by default.

@youkaichao youkaichao deleted the youkaichao-fix-cmake-regex branch April 3, 2024 23:41
sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request Apr 22, 2024
…ytorch#123243)

When people build pytorch extensions with cmake, and the GPU supports 9.0a arch as introduced in pytorch#110587 , the cmake regex is not updated to recognize the change, leading to cmake breaks like pytorch#113948 and pytorch#119946 .

This PR should fix them.
Pull Request resolved: pytorch#123243
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants