Fixes format utils executable #123482
Merged
Fixes format utils executable #123482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with the format utils executable, which was causing it to run as a no-op. :( Pull Request resolved: #123407 Approved by: https://github.com/wz337, https://github.com/fegin (cherry picked from commit 18c9d46)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123482
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 1ab823a with merge base 86a2d67 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: distributed_checkpoint
oncall: distributed
huydhn
added a commit
to pytorch/test-infra
that referenced
this pull request
Apr 9, 2024
This is to address a common source of wrong classifications as shown in #5063 where the merge base commit is too old. This increases the chance of marking actual failures as flaky because the search window could be big. We can relax this once we achieve a higher accuracy with the log classifier as explained in #5063 (comment) ### Testing pytorch/pytorch#123482 has flaky failure and it merge base is a month old. After this change, the flaky failure won't be marked as flaky anymore: <!-- drci-comment-start --> ## 🔗 Helpful Links ### 🧪 See artifacts and rendered test results at [hud.pytorch.org/pr/123482](https://hud.pytorch.org/pr/123482) * 📄 Preview [Python docs built from this PR](https://docs-preview.pytorch.org/pytorch/pytorch/123482/index.html) * 📄 Preview [C++ docs built from this PR](https://docs-preview.pytorch.org/pytorch/pytorch/123482/cppdocs/index.html) * ❓ Need help or want to give feedback on the CI? Visit the [bot commands wiki](https://github.com/pytorch/pytorch/wiki/Bot-commands) or our [office hours](https://github.com/pytorch/pytorch/wiki/Dev-Infra-Office-Hours) Note: Links to docs will display an error until the docs builds have been completed. ## ❌ 2 New Failures As of commit 1ab823a683847d8c01b35bda74143876f922586b with merge base 86a2d67bb9db7dae8ff4589930dd505a6c5b4ec6 (<sub><sub><img alt="image" width=70 src="https://img.shields.io/date/1710217340?label=&color=FFFFFF&style=flat-square"></sub></sub>): <details open><summary><b>NEW FAILURES</b> - The following jobs have failed:</summary><p> * [pull / linux-focal-py3.11-clang10 / test (default, 1, 3, linux.2xlarge)](https://hud.pytorch.org/pr/pytorch/pytorch/123482#23507840916) ([gh](https://github.com/pytorch/pytorch/actions/runs/8576493039/job/23507840916)) `Process completed with exit code 1.` * [pull / linux-jammy-py3.10-clang15-asan / test (default, 6, 6, linux.4xlarge)](https://hud.pytorch.org/pr/pytorch/pytorch/123482#23507963375) ([gh](https://github.com/pytorch/pytorch/actions/runs/8576493039/job/23507963375)) `Process completed with exit code 1.` </p></details> This comment was automatically generated by Dr. CI and updates every 15 minutes. <!-- drci-comment-end -->
huydhn
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the format utils executable, which was causing it to run as a no-op. :(
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @LucasLLC