inductor cpp wrapper: add GIL release back #123897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123897
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit f831a94 with merge base e3ac615 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
jgong5
reviewed
Apr 12, 2024
Comment on lines
523
to
524
| # release GIL to support multiple instances inference (in different threads of the same process) | ||
| self.prefix.splice("pybind11::gil_scoped_release release;") |
There was a problem hiding this comment.
What's the story for config.abi_compatible=True?
There was a problem hiding this comment.
Because in the ABI-compatible mode, we aren't allowed to call dispatcher Boxed call, instead we go back to Python to call custom ops in #122554 (Note: this is only for the JIT mode). If this is really performance critical, you could gil_scoped_release by default, gil_scoped_acquire before entering the custom op call and destroy that gil_scoped_acquire after done with the custom op call.
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
peterbell10
reviewed
Apr 15, 2024
Fixes #123517. This PR adds the GIL release (originally added in #111888) back. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
Fixes #123517. This PR adds the GIL release (originally added in #111888) back. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
peterbell10
approved these changes
Apr 16, 2024
jgong5
approved these changes
Apr 17, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
sanketpurandare
pushed a commit
to sanketpurandare/pytorch
that referenced
this pull request
Apr 22, 2024
Fixes pytorch#123517. This PR adds the GIL release (originally added in pytorch#111888) back following the suggestion here: pytorch#123897 (comment). We added a default constructor and an assignment operator for the `RAIIPyObject` class (pytorch#123897 (comment)) in order to declare the `custom_op_wrapper` outside of the GIL acquisition scope. Pull Request resolved: pytorch#123897 Approved by: https://github.com/peterbell10, https://github.com/jgong5
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
Fixes #123517. This PR adds the GIL release (originally added in #111888) back following the suggestion here: #123897 (comment). We added a default constructor and an assignment operator for the `RAIIPyObject` class (#123897 (comment)) in order to declare the `custom_op_wrapper` outside of the GIL acquisition scope. Pull Request resolved: #123897 Approved by: https://github.com/peterbell10, https://github.com/jgong5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #123517.
This PR adds the GIL release (originally added in #111888) back following the suggestion here: #123897 (comment).
We added a default constructor and an assignment operator for the
RAIIPyObjectclass(#123897 (comment)) in order to declare the
custom_op_wrapperoutside of the GIL acquisition scope.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @amjames @desertfire @chauhang