[caffe2] Make all get_backtrace() implementations lazy #125750
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125750
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (26 Unrelated Failures)As of commit c8f7d65 with merge base 320af5e ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D56881683 |
|
This pull request was exported from Phabricator. Differential Revision: D56881683 |
Summary: pytorch#125682 (D56586844) added support for lazy symbolization to `Error` and adopted it for internal use cases; this commit adopts it for `get_backtrace()` as well. Test Plan: Sandcastle and GH CI. Differential Revision: D56881683
|
This pull request was exported from Phabricator. Differential Revision: D56881683 |
ezyang
approved these changes
May 10, 2024
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m="Diff reverted internally" -c="ghfirst" This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).) |
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
May 10, 2024
…)" This reverts commit cc4da72. Reverted #125750 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#125750 (comment)))
|
@ot your PR has been successfully reverted. |
pytorchmergebot
pushed a commit
that referenced
this pull request
May 13, 2024
…6064) Summary: #125682 (D56586844) added support for lazy symbolization to `Error` and adopted it for internal use cases; this commit adopts it for `get_backtrace()` as well. Test Plan: Sandcastle and GH CI. NOTE: This is a resubmit of D56881683, a spurious copypasted line in the Android implementation broke the build, but this was not surfaced by diff tests. Reproed the breakage with ``` $ fbpython scripts/build_android_app/build_android_app.py --buck-config-files='@//fbandroid/mode/have_libgflags @//fbandroid/mode/static_linking @//xplat/langtech/mobile/android_opt_buck_config_with_et_boltnn' --build-target='fbsource//xplat/langtech/mobile:transcribe_binAndroid-android-arm64' ``` Verified that the fixed diff builds successfully. Differential Revision: D57275456 Pull Request resolved: #126064 Approved by: https://github.com/ezyang
tinglvv
pushed a commit
to tinglvv/pytorch
that referenced
this pull request
May 14, 2024
…ch#125750)" This reverts commit cc4da72. Reverted pytorch#125750 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#125750 (comment)))
tinglvv
pushed a commit
to tinglvv/pytorch
that referenced
this pull request
May 14, 2024
… (pytorch#126064) Summary: pytorch#125682 (D56586844) added support for lazy symbolization to `Error` and adopted it for internal use cases; this commit adopts it for `get_backtrace()` as well. Test Plan: Sandcastle and GH CI. NOTE: This is a resubmit of D56881683, a spurious copypasted line in the Android implementation broke the build, but this was not surfaced by diff tests. Reproed the breakage with ``` $ fbpython scripts/build_android_app/build_android_app.py --buck-config-files='@//fbandroid/mode/have_libgflags @//fbandroid/mode/static_linking @//xplat/langtech/mobile/android_opt_buck_config_with_et_boltnn' --build-target='fbsource//xplat/langtech/mobile:transcribe_binAndroid-android-arm64' ``` Verified that the fixed diff builds successfully. Differential Revision: D57275456 Pull Request resolved: pytorch#126064 Approved by: https://github.com/ezyang
|
Any updates on this? |
|
This was re-submitted and merged as #126064, I'll close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: #125682 (D56586844) added support for lazy symbolization to
Errorand adopted it for internal use cases; this commit adopts it forget_backtrace()as well.Test Plan: Sandcastle and GH CI.
Differential Revision: D56881683