Make ValueRange repr less chatty by default #128043

ezyang · 2024-06-05T17:38:44Z

Stack from ghstack (oldest at bottom):

-> Make ValueRange repr less chatty by default #128043

Signed-off-by: Edward Z. Yang ezyang@meta.com

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang

[ghstack-poisoned]

pytorch-bot · 2024-06-05T17:38:48Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128043

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

Rebase your PRs: Unstable CUDA signal in CI caused by cudnn 9 update

❌ 1 New Failure, 7 Unrelated Failures

As of commit 29acbb9 with merge base f08fd8e ():

NEW FAILURE - The following job has failed:

trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
inductor/test_efficient_conv_bn_eval.py::EfficientConvBNEvalCudaTests::test_basic_cuda

FLAKY - The following job failed but was likely due to flakiness present on trunk:

linux-binary-manywheel / manywheel-py3_8-cuda11_8-test / test (gh) (similar failure)
ImportError: libcudnn.so.9: cannot open shared object file: No such file or directory

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-py3.8-clang10-onnx / test (default, 1, 2, linux.2xlarge) (gh) (trunk failure)
onnx/test_fx_op_consistency.py::TestOnnxModelOutputConsistency_opset_version_18_model_type_TorchModelType.TORCH_NN_MODULECPU::test_output_match_alias_copy_cpu_complex64
pull / linux-focal-py3.8-clang10-onnx / test (default, 2, 2, linux.2xlarge) (gh) (trunk failure)
onnx/test_fx_op_consistency.py::TestOnnxModelOutputConsistency_opset_version_18_model_type_TorchModelType.TORCH_NN_MODULECPU::test_output_match_alias_copy_cpu_bool
trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-13) (gh) (trunk failure)
test_mps.py::TestConsistencyCPU::test_output_match_alias_copy_cpu_complex64
trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-14) (gh) (trunk failure)
test_mps.py::TestConsistencyCPU::test_output_match_alias_copy_cpu_complex64

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

linux-binary-manywheel / manywheel-py3_8-cuda12_1-test / test (gh) (#127288)
ImportError: libcudnn.so.9: cannot open shared object file: No such file or directory
linux-binary-manywheel / manywheel-py3_8-cuda12_4-test / test (gh) (#127289)
ImportError: libcudnn.so.9: cannot open shared object file: No such file or directory

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: bb92f38 Pull Request resolved: #128043

lezcano

<3

lezcano · 2024-06-05T21:29:57Z

lint is complaining tho

[ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 9110663 Pull Request resolved: #128043

lezcano · 2024-06-06T07:45:25Z

@pytorchbot merge

pytorchmergebot · 2024-06-06T07:47:15Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-06-06T13:28:54Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 2f4e8712ec1c65e60a2f1610d86e35d4d45bd8ec returned non-zero exit code 1

Auto-merging test/dynamo/test_misc.py
CONFLICT (content): Merge conflict in test/dynamo/test_misc.py
Auto-merging torch/utils/_sympy/value_ranges.py
error: could not apply 2f4e8712ec1... Make ValueRange repr less chatty by default
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

[ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 9f95d84 Pull Request resolved: #128043

ezyang · 2024-06-06T16:39:59Z

@pytorchbot merge -f "ci failures look unrelated"

pytorchmergebot · 2024-06-06T16:42:36Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

atalman · 2024-06-07T15:41:57Z

@pytorchmergebot revert -c ghfirst -m "Sorry reverting because in conflict with #126905 which needs to be reverted"

pytorchmergebot · 2024-06-07T15:43:29Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2024-06-07T15:43:42Z

@ezyang your PR has been successfully reverted.

This reverts commit f0dd11d. Reverted #128043 on behalf of https://github.com/atalman due to Sorry reverting because in conflict with [#126905](#126905) which needs to be reverted ([comment](#128043 (comment)))

atalman · 2024-06-07T16:03:44Z

@pytorchmergebot rebase -b main

pytorchmergebot · 2024-06-07T16:05:18Z

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

pytorchmergebot · 2024-06-07T16:05:25Z

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/9419893823

Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#128043 Approved by: https://github.com/lezcano

This reverts commit f0dd11d. Reverted pytorch#128043 on behalf of https://github.com/atalman due to Sorry reverting because in conflict with [pytorch#126905](pytorch#126905) which needs to be reverted ([comment](pytorch#128043 (comment)))

Update

d45a6b6

[ghstack-poisoned]

pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Jun 5, 2024

github-actions bot requested review from SherlockNoMad, albanD, antoniojkim, bdhirsh and miladm June 5, 2024 17:38

ezyang requested review from lezcano and shazqadeer June 5, 2024 19:25

Update

48cb3af

[ghstack-poisoned]

pytorch-bot bot added the module: dynamo label Jun 5, 2024

ezyang added a commit that referenced this pull request Jun 5, 2024

Make ValueRange repr less chatty by default

390b3ac

Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: bb92f38 Pull Request resolved: #128043

lezcano approved these changes Jun 5, 2024

View reviewed changes

lezcano added the release notes: dynamo label Jun 5, 2024

Update

e7a5f48

[ghstack-poisoned]

ezyang added a commit that referenced this pull request Jun 6, 2024

Make ValueRange repr less chatty by default

2f4e871

Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 9110663 Pull Request resolved: #128043

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 6, 2024

pytorchmergebot added the merging label Jun 6, 2024

pytorchmergebot removed the merging label Jun 6, 2024

Update

29acbb9

[ghstack-poisoned]

ezyang added a commit that referenced this pull request Jun 6, 2024

Make ValueRange repr less chatty by default

ae66913

Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: 9f95d84 Pull Request resolved: #128043

pytorchmergebot added the merging label Jun 6, 2024

pytorchmergebot closed this in f0dd11d Jun 6, 2024

pytorchmergebot added Merged and removed merging labels Jun 6, 2024

pytorchmergebot added the Reverted label Jun 7, 2024

pytorchmergebot reopened this Jun 7, 2024

ezyang closed this Jun 10, 2024

github-actions bot deleted the gh/ezyang/2801/head branch July 10, 2024 16:24

Make ValueRange repr less chatty by default #128043

Make ValueRange repr less chatty by default #128043

Uh oh!

Conversation

ezyang commented Jun 5, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128043

❗ 1 Active SEVs

❌ 1 New Failure, 7 Unrelated Failures

Uh oh!

lezcano left a comment

Choose a reason for hiding this comment

Uh oh!

lezcano commented Jun 5, 2024

Uh oh!

lezcano commented Jun 6, 2024

Uh oh!

pytorchmergebot commented Jun 6, 2024

Merge started

Uh oh!

pytorchmergebot commented Jun 6, 2024

Merge failed

Uh oh!

ezyang commented Jun 6, 2024

Uh oh!

pytorchmergebot commented Jun 6, 2024

Merge started

Uh oh!

atalman commented Jun 7, 2024

Uh oh!

pytorchmergebot commented Jun 7, 2024

Uh oh!

pytorchmergebot commented Jun 7, 2024

Uh oh!

atalman commented Jun 7, 2024

Uh oh!

pytorchmergebot commented Jun 7, 2024

Uh oh!

pytorchmergebot commented Jun 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ezyang commented Jun 5, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Jun 5, 2024 •

edited

Loading