KEMBAR78
More appropriate socket errors and debug messages by mwlon · Pull Request #130347 · pytorch/pytorch · GitHub
Skip to content

More appropriate socket errors and debug messages #130347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

More appropriate socket errors and debug messages #130347

wants to merge 2 commits into from

Conversation

@mwlon
Copy link
Contributor

@mwlon mwlon commented Jul 9, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130347

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit abb2982 with merge base 6241006 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 9, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Jul 9, 2024
@janeyx99 janeyx99 requested a review from wconstab July 10, 2024 15:03
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 10, 2024
@fduwjj
Copy link
Contributor

fduwjj commented Jul 17, 2024

This looks good to me, I think you need to first get CLA Authorization.

@mwlon
Copy link
Contributor Author

mwlon commented Jul 18, 2024

@fduwjj yep, we had logistical difficulties with easyCLA, but they should be resolved now.

@yf225 yf225 requested a review from fduwjj July 20, 2024 20:59
@mwlon
Copy link
Contributor Author

mwlon commented Jul 31, 2024

@fduwjj Can you review?

@mwlon
Copy link
Contributor Author

mwlon commented Aug 12, 2024

@fduwjj @yf225 ping

fduwjj
fduwjj approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwlon
Copy link
Contributor Author

mwlon commented Sep 15, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 15, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 5 jobs have failed, first few of them are: trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build / build, trunk / linux-focal-cuda11.8-py3.10-gcc9-experimental-split-build / build, trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / build, trunk / linux-focal-cuda12.4-py3.10-gcc9-no-ops / build, trunk / linux-focal-cuda12.1-py3.10-gcc9-no-ops / build

Details for Dev Infra team Raised by workflow job

@mwlon
Copy link
Contributor Author

mwlon commented Sep 18, 2024

@pytorchbot rebase

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 18, 2024

You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra.

@mwlon mwlon force-pushed the fix-spurious-socket-warnings branch from 2cabda4 to 1a5037d Compare September 18, 2024 20:15
@mwlon
Copy link
Contributor Author

mwlon commented Sep 22, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mwlon
Copy link
Contributor Author

mwlon commented Sep 23, 2024

@fduwjj I keep getting failures, but I don't think any of them are related to this PR. How can I get past these?

@mwlon
Copy link
Contributor Author

mwlon commented Sep 30, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mwlon
Copy link
Contributor Author

mwlon commented Oct 2, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@fduwjj
Copy link
Contributor

fduwjj commented Oct 21, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

SamGinzburg pushed a commit that referenced this pull request Oct 28, 2024
@mwlon @SamGinzburg
More appropriate socket errors and debug messages (#130347)
55c1b72 
Fixes #128998

Pull Request resolved: #130347
Approved by: https://github.com/fduwjj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fduwjj fduwjj fduwjj approved these changes

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (c10d) release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spurious "socket cannot be initialized" error messages

5 participants

@mwlon @fduwjj @pytorchmergebot @pytorchbot @janeyx99