KEMBAR78
Move trunk windows builds to CUDA-12.1 by malfet · Pull Request #130446 · pytorch/pytorch · GitHub
Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Jul 10, 2024

That should catch build regressions that were previously only detectable during the nightly builds
Win + CUDA-11.8 builds and tests are still run as part of periodic workflow

@malfet malfet requested a review from a team as a code owner July 10, 2024 16:31
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130446

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 6e4b941 with merge base a205a53 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 10, 2024
@malfet malfet added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 10, 2024
@malfet
Copy link
Contributor Author

malfet commented Jul 11, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased malfet-patch-1 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout malfet-patch-1 && git pull --rebase)

@malfet
Copy link
Contributor Author

malfet commented Jul 11, 2024

@pytorchbot merge -f "Lint + win-vs2019-cuda12.1 builds are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet deleted the malfet-patch-1 branch July 12, 2024 15:13
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
That should catch build regressions that were previously only detectable during the nightly builds
Win + CUDA-11.8 builds and tests are still run as part of periodic workflow
Pull Request resolved: pytorch#130446
Approved by: https://github.com/atalman
pytorchmergebot pushed a commit that referenced this pull request Jan 28, 2025
Same as : #130446

That should catch build regressions that were previously only detectable during the nightly builds for 12.4

Pull Request resolved: #145844
Approved by: https://github.com/janeyx99, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants