KEMBAR78
Replace [[unlikely]] with unlikely(x) by Danielmic · Pull Request #130816 · pytorch/pytorch · GitHub
Skip to content

Replace [[unlikely]] with unlikely(x) #130816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Replace [[unlikely]] with unlikely(x) #130816

wants to merge 1 commit into from

Conversation

@Danielmic
Copy link
Contributor

@Danielmic Danielmic commented Jul 16, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130816

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9b5e3fa with merge base 919e384 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 16, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Danielmic / name: Danielmic (9b5e3fa)

@Danielmic Danielmic mentioned this pull request Jul 16, 2024
Closed
@soulitzer soulitzer requested review from jansel and jgong5 July 18, 2024 00:56
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 18, 2024
jgong5
jgong5 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@jgong5 jgong5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the minimal GCC version PyTorch supports is GCC9?

@malfet malfet added this to the 2.4.1 milestone Aug 7, 2024
@malfet
Copy link
Contributor

malfet commented Aug 7, 2024

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 7, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased Danielmic-fix-likely-issue-on-compiler onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout Danielmic-fix-likely-issue-on-compiler && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the Danielmic-fix-likely-issue-on-compiler branch from b05fcf9 to 9b5e3fa Compare August 7, 2024 07:10
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor

atalman commented Aug 15, 2024 •
edited
Loading

@pytorchbot cherry-pick --onto release/2.4 -c critical --fixes #130815

pytorchbot pushed a commit that referenced this pull request Aug 15, 2024
@Danielmic @pytorchbot
Replace [[unlikely]] with unlikely(x) (#130816)
a7c7c33 
Do not use `[[unlikely]]` as its c++20 language features, see https://en.cppreference.com/w/cpp/language/attributes/likely

Fixes #130815

Pull Request resolved: #130816
Approved by: https://github.com/jgong5, https://github.com/jansel, https://github.com/malfet

(cherry picked from commit 32f9a80)
@pytorchbot
Copy link
Collaborator

Cherry picking #130816

The cherry pick PR is at #133583 and it is linked with issue #30815. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Aug 15, 2024
Closed
atalman pushed a commit that referenced this pull request Aug 20, 2024
@pytorchbot @Danielmic
Replace [[unlikely]] with unlikely(x) (#133583)
d3d93a8 
Replace [[unlikely]] with unlikely(x) (#130816)

Do not use `[[unlikely]]` as its c++20 language features, see https://en.cppreference.com/w/cpp/language/attributes/likely

Fixes #130815

Pull Request resolved: #130816
Approved by: https://github.com/jgong5, https://github.com/jansel, https://github.com/malfet

(cherry picked from commit 32f9a80)

Co-authored-by: Danielmic <30855238+Danielmic@users.noreply.github.com>
@atalman atalman mentioned this pull request Aug 28, 2024
Closed
40 tasks
@eqy eqy mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@malfet malfet malfet approved these changes

@jgong5 jgong5 jgong5 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source release notes: inductor topic: bug fixes topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

2.4.1

Development

Successfully merging this pull request may close these issues.

[inductor] build failed with gcc8.3

8 participants

@Danielmic @malfet @pytorchmergebot @atalman @pytorchbot @jansel @jgong5 @soulitzer