Add decomps for max_unpool #133146

isuruf · 2024-08-09T23:42:49Z

Stack from ghstack (oldest at bottom):

-> Add decomps for max_unpool #133146

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

[ghstack-poisoned]

pytorch-bot · 2024-08-09T23:42:52Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133146

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 05d8284 with merge base 803ce50 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 8273aa3 Pull Request resolved: #133146

[ghstack-poisoned]

ghstack-source-id: 6413271 Pull Request resolved: #133146

amjames

Not seeing anything to comment on, but can we see a benchmark sweep?

[ghstack-poisoned]

ghstack-source-id: 405cc48 Pull Request resolved: #133146

isuruf · 2024-09-06T20:55:20Z

Benchmark results with out_size being 2 times the shape

[------------------------- max_unpool ------------------------]
                                        |  Decomposed  |  Eager
12 threads: ---------------------------------------------------
      {'shape': (3, 5, 2000, 2000)}     |     2472     |   5334
      {'shape': (3, 5, 1000, 1000)}     |      628     |   1350
      {'shape': (3, 5, 200, 200, 200)}  |     8081     |  15360
      {'shape': (3, 5, 100, 100, 100)}  |     1024     |   1768

amjames · 2024-09-11T17:03:46Z

@pytorchbot merge

pytorchmergebot · 2024-09-11T17:05:38Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-11T17:16:10Z

Merge failed

Reason: 5 jobs have failed, first few of them are: trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / build, trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build / build, trunk / linux-focal-cuda12.4-py3.10-gcc9-no-ops / build, trunk / linux-focal-cuda11.8-py3.10-gcc9-experimental-split-build / build, trunk / linux-focal-cuda12.1-py3.10-gcc9-no-ops / build

Details for Dev Infra team

Raised by workflow job

isuruf · 2024-09-19T21:12:14Z

@pytorchbot merge -r

pytorchmergebot · 2024-09-19T21:13:48Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]

pytorchmergebot · 2024-09-19T21:13:59Z

Successfully rebased gh/isuruf/76/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/133146)

ghstack-source-id: bb8ac22 Pull Request resolved: #133146

pytorchmergebot · 2024-09-19T21:15:15Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-20T03:12:43Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

isuruf · 2024-09-20T16:09:53Z

@pytorchbot merge

pytorchmergebot · 2024-09-20T16:12:23Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Revert "[PT2][Inductor][Optmus] fix test_pad_mm_bf16 and reland to fix long computation kernel (#136349)" This reverts commit e184391. Revert "Fix clang-tidy warnings in torch/csrc/lazy (#134655)" This reverts commit 0287146. Revert "Remove duplicate line (#136383)" This reverts commit 0b91e7e. Revert "[TF32] Account for TF32 in `test_conv_double_backward` (#135716)" This reverts commit 29f7b8d. Revert "Fix `Vectorized<double>::next_after` SVE compilation (#136388)" This reverts commit 7936584. Revert "Upgrade pybind11 API calls for 3.13t (#136370)" This reverts commit 067d203. Revert "[AOTI][Tooling] Filter out kernels based off lowercase names (#135395)" This reverts commit 1a10751. Revert "Add decomps for max_unpool (#133146)" This reverts commit 0c936c3. Revert "add TORCH_CUDA_CPP_API for AutoNcclGroup (#130012)" This reverts commit 293fccf. Revert "Use cpython declaration of _PyWeakref_ClearRef (#136300)" This reverts commit d2455b9. Revert "fix mypi in utils/_sympy/functions.py (#136339)" This reverts commit 7f9c064. Revert "[Inductor] Fix test_profiler_mark_wrapper_call_cuda_cuda_wrapper (#136356)" This reverts commit f53a0f9. Revert "Add more distributed examples (#130427)" This reverts commit 5997354. Revert "return instead of using skipTest (#136244)" This reverts commit 29affa6. Reapply "[PT2/Profiler] Add Context Info to Torch-Compiled Regions (#132765)" This reverts commit 783c5ba. Revert "Enable torch build with SLEEF on ARM by default (#133339)" This reverts commit 4842f0f. Revert "[inductor] Relax the conditions for loop split (#135335)" This reverts commit 687e5cf. [ghstack-poisoned]

Revert "[PT2][Inductor][Optmus] fix test_pad_mm_bf16 and reland to fix long computation kernel (#136349)" This reverts commit e184391. Revert "Fix clang-tidy warnings in torch/csrc/lazy (#134655)" This reverts commit 0287146. Revert "Remove duplicate line (#136383)" This reverts commit 0b91e7e. Revert "[TF32] Account for TF32 in `test_conv_double_backward` (#135716)" This reverts commit 29f7b8d. Revert "Fix `Vectorized<double>::next_after` SVE compilation (#136388)" This reverts commit 7936584. Revert "Upgrade pybind11 API calls for 3.13t (#136370)" This reverts commit 067d203. Revert "[AOTI][Tooling] Filter out kernels based off lowercase names (#135395)" This reverts commit 1a10751. Revert "Add decomps for max_unpool (#133146)" This reverts commit 0c936c3. Revert "add TORCH_CUDA_CPP_API for AutoNcclGroup (#130012)" This reverts commit 293fccf. Revert "Use cpython declaration of _PyWeakref_ClearRef (#136300)" This reverts commit d2455b9. Revert "fix mypi in utils/_sympy/functions.py (#136339)" This reverts commit 7f9c064. Revert "[Inductor] Fix test_profiler_mark_wrapper_call_cuda_cuda_wrapper (#136356)" This reverts commit f53a0f9. Revert "Add more distributed examples (#130427)" This reverts commit 5997354. Revert "return instead of using skipTest (#136244)" This reverts commit 29affa6. Reapply "[PT2/Profiler] Add Context Info to Torch-Compiled Regions (#132765)" This reverts commit 783c5ba. Revert "Enable torch build with SLEEF on ARM by default (#133339)" This reverts commit 4842f0f. Revert "[inductor] Relax the conditions for loop split (#135335)" This reverts commit 687e5cf. ghstack-source-id: b0fb91e Pull Request resolved: #136668

Update

74f8c98

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: inductor labels Aug 9, 2024

isuruf added a commit that referenced this pull request Aug 9, 2024

Add decomps for max_unpool

a814b02

ghstack-source-id: 8273aa3 Pull Request resolved: #133146

pytorchbot added the open source label Aug 9, 2024

Update

fd494b6

[ghstack-poisoned]

isuruf added the release notes: inductor label Aug 12, 2024

Update

9d56b9a

[ghstack-poisoned]

Update

96ce1d4

[ghstack-poisoned]

Update

4a17eba

[ghstack-poisoned]

Update

9e66ef4

[ghstack-poisoned]

Update

a96ab63

[ghstack-poisoned]

isuruf requested a review from mruberry as a code owner August 13, 2024 16:30

isuruf added a commit that referenced this pull request Aug 13, 2024

Add decomps for max_unpool

ba11600

ghstack-source-id: 6413271 Pull Request resolved: #133146

isuruf requested a review from amjames August 15, 2024 15:04

amjames reviewed Aug 15, 2024

View reviewed changes

Update

d11c845

[ghstack-poisoned]

isuruf added a commit that referenced this pull request Aug 19, 2024

Add decomps for max_unpool

a0fb150

ghstack-source-id: 405cc48 Pull Request resolved: #133146

amjames approved these changes Sep 10, 2024

View reviewed changes

amjames requested a review from eellison September 10, 2024 15:34

eellison approved these changes Sep 10, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 11, 2024

pytorchmergebot added the merging label Sep 11, 2024

pytorchmergebot removed the merging label Sep 11, 2024

Update

05d8284

[ghstack-poisoned]

pytorchmergebot pushed a commit that referenced this pull request Sep 19, 2024

Add decomps for max_unpool

8d7f504

ghstack-source-id: bb8ac22 Pull Request resolved: #133146

pytorchmergebot added the merging label Sep 19, 2024

pytorchmergebot added the Merged label Sep 20, 2024

pytorchmergebot closed this in 0c936c3 Sep 20, 2024

pytorchmergebot removed the merging label Sep 20, 2024

zou3519 mentioned this pull request Sep 25, 2024

Revert a bunch of stuff #136668

Closed

github-actions bot deleted the gh/isuruf/76/head branch October 21, 2024 02:08

Add decomps for max_unpool #133146

Add decomps for max_unpool #133146

Uh oh!

Conversation

isuruf commented Aug 9, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133146

✅ No Failures

Uh oh!

amjames left a comment

Choose a reason for hiding this comment

Uh oh!

isuruf commented Sep 6, 2024

Uh oh!

amjames commented Sep 11, 2024

Uh oh!

pytorchmergebot commented Sep 11, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 11, 2024

Merge failed

Uh oh!

isuruf commented Sep 19, 2024

Uh oh!

pytorchmergebot commented Sep 19, 2024

Uh oh!

pytorchmergebot commented Sep 19, 2024

Uh oh!

pytorchmergebot commented Sep 19, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 20, 2024

Uh oh!

isuruf commented Sep 20, 2024

Uh oh!

pytorchmergebot commented Sep 20, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

isuruf commented Aug 9, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Aug 9, 2024 •

edited

Loading