KEMBAR78
Clarify meaning of rate parameter in Gamma distribution by psteinb · Pull Request #134847 · pytorch/pytorch · GitHub
Skip to content

Conversation

@psteinb
Copy link
Contributor

@psteinb psteinb commented Aug 30, 2024

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134847

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit de89ec0 with merge base 81ecf98 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 30, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@colesbury
Copy link
Member

This change doesn't look correct to me. https://en.wikipedia.org/wiki/Gamma_distribution ⁠described β as the "rate parameter" (i.e., inverse scale parameter)

@colesbury colesbury requested review from albanD and ezyang September 3, 2024 18:41
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Nov 2, 2024
@psteinb
Copy link
Contributor Author

psteinb commented Nov 4, 2024

Thanks @colesbury and sorry for the confusion in my post above. I tried to improve my PR to make it easier for people to understand what is meant. If that is not suitable, feel free to close this PR.

@ezyang ezyang requested review from alicanb and fritzo November 5, 2024 20:06
Copy link
Collaborator

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simply english usage disambiguation

@fritzo
Copy link
Collaborator

fritzo commented Nov 6, 2024

The code change looks fline. The PR description looks to be in error, however.

@ezyang ezyang changed the title clarify constructor argument naming for the Gamma distribution Clarify meaning of rate parameter in Gamma distribution Nov 7, 2024
@ezyang ezyang added release notes: python_frontend python frontend release notes category topic: docs topic category and removed Stale labels Nov 7, 2024
@ezyang
Copy link
Contributor

ezyang commented Nov 7, 2024

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 7, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased patch-1 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout patch-1 && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ezyang
Copy link
Contributor

ezyang commented Nov 7, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor

ezyang commented Nov 9, 2024

@pytorchbot merge -f "make no trouble"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Nov 11, 2024
zero000064 pushed a commit to zero000064/pytorch that referenced this pull request Nov 14, 2024
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
fmo-mt pushed a commit to fmo-mt/pytorch that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend python frontend release notes category topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants