KEMBAR78
Add missing input "eps" to adam docs by Sunishchal · Pull Request #135191 · pytorch/pytorch · GitHub
Skip to content

Add missing input "eps" to adam docs #135191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add missing input "eps" to adam docs #135191

wants to merge 2 commits into from

Conversation

@Sunishchal
Copy link
Contributor

Minor fix for missing input argument in the Adam optimizer docs page.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135191

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b432ec4 with merge base 780f4de (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 5, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

janeyx99
janeyx99 reviewed Sep 5, 2024
View reviewed changes
torch/optim/adam.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to after the maximize?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include a docs preview when you get the chance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @janeyx99 I've made the requested change. Just waiting for approval on the CI pipeline before the docs update. Here is the docs preview on the original version of the PR.
image

@albanD albanD removed their request for review September 5, 2024 22:04
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 6, 2024
janeyx99
janeyx99 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@janeyx99
Copy link
Contributor

Sorry I've been busy the weeks up to the conference, only catching up on notifs now. Thanks for the edit!

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 25, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased patch-1 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout patch-1 && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
@Sunishchal @BoyuanFeng
Add missing input "eps" to adam docs (pytorch#135191)
2886552 
Minor fix for missing input argument in the Adam optimizer docs page.

Pull Request resolved: pytorch#135191
Approved by: https://github.com/janeyx99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: optim triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sunishchal @janeyx99 @pytorchmergebot @soulitzer @pytorchbot