torch/ao/quantization/utils.py: Moving eps to targeted device to avoid device mismatch issue #135204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d device mismatch issue
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135204
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7a4033b with merge base 5b442e8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
release notes: quantization
soulitzer
added
the
triaged
jgong5
approved these changes
Sep 10, 2024
jerryzh168
approved these changes
Oct 14, 2024
…d device mismatch issue
…into fix_eps_device
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
aostrowski-hbn
pushed a commit
to HabanaAI/pytorch-fork
that referenced
this pull request
Jan 7, 2025
…, move eps to device of other tensors to avoid device mismatch issue. 2) pytorch upstream pr: pytorch#135204. This pull request is merged. Change-Id: I52cad8dda1df4952bbdb2e4bc8eb39d9ab3e800f Signed-off-by:: internal developer <developer@habana.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOTIVATION
We recently verified some quantization tests on devices other than cpu (eg. CUDA and Intel Gaudi devices identified as 'hpu'). We noticed a device mismatch error as eps is a tensor created on cpu but other tensors (min_val_neg, max_val_pos, scale, zero_point) are moved to the targeted device.
CHANGES
Move eps to device of other tensors.