KEMBAR78
[inductor] Flip custom_op_default_layout_constraint by zou3519 · Pull Request #135239 · pytorch/pytorch · GitHub
Skip to content

[inductor] Flip custom_op_default_layout_constraint #135239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[inductor] Flip custom_op_default_layout_constraint #135239

wants to merge 5 commits into from

Conversation

@zou3519
Copy link
Contributor

@zou3519 zou3519 commented Sep 5, 2024 •
edited by pytorch-bot bot
Loading

@zou3519
[inductor] Flip custom_op_default_layout_constraint
4fd483d 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135239

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f6b3cbe with merge base b7eb725 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zou3519 added a commit that referenced this pull request Sep 5, 2024
@zou3519
[inductor] Flip custom_op_default_layout_constraint
64c1e31 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

ghstack-source-id: 937563e
Pull Request resolved: #135239
@zou3519 zou3519 added ciflow/trunk Trigger trunk jobs on your pull request ci-no-td Do not run TD on this PR release notes: inductor labels Sep 5, 2024
@zou3519
Update on "[inductor] Flip custom_op_default_layout_constraint"
b9a5fb1 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Sep 5, 2024
@zou3519
[inductor] Flip custom_op_default_layout_constraint
d10a429 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

ghstack-source-id: f236b67
Pull Request resolved: #135239
@zou3519
Update on "[inductor] Flip custom_op_default_layout_constraint"
170f03f 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Sep 5, 2024
@zou3519
[inductor] Flip custom_op_default_layout_constraint
ce2e902 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

ghstack-source-id: 86e240c
Pull Request resolved: #135239
@zou3519
Update on "[inductor] Flip custom_op_default_layout_constraint"
d0cb32e 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@zou3519 zou3519 mentioned this pull request Sep 6, 2024
Closed
zou3519 added a commit that referenced this pull request Sep 6, 2024
@zou3519
[inductor] Flip custom_op_default_layout_constraint
115a859 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

ghstack-source-id: 860e4d1
Pull Request resolved: #135239
@zou3519
Update on "[inductor] Flip custom_op_default_layout_constraint"
f6b3cbe 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Sep 9, 2024
@zou3519
[inductor] Flip custom_op_default_layout_constraint
a035a71 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

ghstack-source-id: f62378f
Pull Request resolved: #135239
@zou3519 zou3519 requested a review from albanD September 9, 2024 17:04
albanD
albanD approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM if we can land it!

@zou3519 zou3519 requested review from FindHao and eellison September 9, 2024 20:19
@zou3519
Copy link
Contributor Author

zou3519 commented Sep 9, 2024

I'm planning on landing this after the branch cut because it is relatively risky

@FindHao
Copy link
Member

FindHao commented Sep 9, 2024

This config will only affect custom ops written by users, right? it will not have performance or correctness influence on the benchmarks in our dashboard, right?

@zou3519 zou3519 mentioned this pull request Sep 9, 2024
Closed
@zou3519
Copy link
Contributor Author

zou3519 commented Sep 10, 2024

This config will only affect custom ops written by users, right? it will not have performance or correctness influence on the benchmarks in our dashboard, right?

I don't know if there are custom ops in our dashboard. If there are any then it may affect them. So we can also watch the dashboard after merging this.

@zou3519
Copy link
Contributor Author

zou3519 commented Sep 10, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

yushangdi pushed a commit that referenced this pull request Sep 12, 2024
@zou3519 @yushangdi
[inductor] Flip custom_op_default_layout_constraint (#135239)
26c2aef 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

Pull Request resolved: #135239
Approved by: https://github.com/albanD
ghstack dependencies: #135391
tolleybot pushed a commit to tolleybot/pytorch that referenced this pull request Sep 14, 2024
@zou3519 @tolleybot
[inductor] Flip custom_op_default_layout_constraint (pytorch#135239)
821138f 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

Pull Request resolved: pytorch#135239
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#135391
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@zou3519 @Chao1Han
[inductor] Flip custom_op_default_layout_constraint (pytorch#135239)
c8bb1af 
By default, Inductor should respect the stride order of input Tensors to
custom operators.

Test Plan:
- new tests

Pull Request resolved: pytorch#135239
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#135391
@github-actions github-actions bot deleted the gh/zou3519/1064/head branch October 12, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@FindHao FindHao Awaiting requested review from FindHao

@eellison eellison Awaiting requested review from eellison

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: inductor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zou3519 @FindHao @pytorchmergebot @albanD