KEMBAR78
Fix return type of `nansum` example. by PhilipMay · Pull Request #135435 · pytorch/pytorch · GitHub
Skip to content

Conversation

@PhilipMay
Copy link
Contributor

One of the examples in the documentation of torch.nansum contains a wrong return type. This fixes it.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135435

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit e27b365 with merge base 042f2f7 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: python_frontend python frontend release notes category label Sep 8, 2024
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 8, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@ezyang ezyang added the topic: docs topic category label Sep 9, 2024
@ezyang
Copy link
Contributor

ezyang commented Sep 9, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 9, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@PhilipMay
Copy link
Contributor Author

Hi @ezyang . Thanks for approval and merging.
Just one short question: Why is this PR showing up as "closed" instead of "merged"?

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
One of the examples in the documentation of `torch.nansum` contains a wrong return type. This fixes it.
Pull Request resolved: pytorch#135435
Approved by: https://github.com/ezyang
apakbin pushed a commit to apakbin/pytorch that referenced this pull request Feb 14, 2025
One of the examples in the documentation of `torch.nansum` contains a wrong return type. This fixes it.
Pull Request resolved: pytorch#135435
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend python frontend release notes category topic: docs topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants