[ONNX] Drop final None values as inputs for nodes in exporter graph #135520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhambhokare1
requested review from
justinchuby,
titaiwangms and
wschin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135520
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 12635bc with merge base 5f7d956 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
shubhambhokare1
changed the title
justinchuby
reviewed
Sep 9, 2024
justinchuby
reviewed
Sep 9, 2024
justinchuby
approved these changes
Sep 9, 2024
|
@pytorchbot merge |
justinchuby
added
module: onnx
|
The release was cut: https://github.com/pytorch/pytorch/commits/release/2.5/ This may need cherry-picking @shubhambhokare1 |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
justinchuby
added a commit
to justinchuby/torch-onnx
that referenced
this pull request
Sep 9, 2024
justinchuby
added a commit
to justinchuby/torch-onnx
that referenced
this pull request
Sep 9, 2024
shubhambhokare1
added a commit
to shubhambhokare1/pytorch
that referenced
this pull request
Sep 17, 2024
…ytorch#135520) When value for an optional input is not provided, it is defaulted to `None`, which gets translates to "" in the onnx graph. To avoid this, if we have a list of inputs and the final few are all `None`, strip them in the graph. Pull Request resolved: pytorch#135520 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit e2f9a83)
This was referenced Sep 17, 2024
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
…ytorch#135520) When value for an optional input is not provided, it is defaulted to `None`, which gets translates to "" in the onnx graph. To avoid this, if we have a list of inputs and the final few are all `None`, strip them in the graph. Pull Request resolved: pytorch#135520 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
kit1980
pushed a commit
that referenced
this pull request
Sep 20, 2024
…d Drop final None values as inputs for nodes in exporter graph (#135520) (#136005) * [ONNX] Update fake mode usage in onnx docs (#135512) Update fake mode usage in onnx docs Pull Request resolved: #135512 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 66db61f) * [ONNX] Drop final None values as inputs for nodes in exporter graph (#135520) When value for an optional input is not provided, it is defaulted to `None`, which gets translates to "" in the onnx graph. To avoid this, if we have a list of inputs and the final few are all `None`, strip them in the graph. Pull Request resolved: #135520 Approved by: https://github.com/justinchuby Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit e2f9a83)
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When value for an optional input is not provided, it is defaulted to
None, which gets translates to "" in the onnx graph. To avoid this, if we have a list of inputs and the final few are allNone, strip them in the graph.