KEMBAR78
Add some minor doc improvement and ban using training IR for unflattener by tugsbayasgalan · Pull Request #135549 · pytorch/pytorch · GitHub
Skip to content

Add some minor doc improvement and ban using training IR for unflattener #135549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add some minor doc improvement and ban using training IR for unflattener #135549

wants to merge 3 commits into from

Conversation

@tugsbayasgalan
Copy link
Contributor

@tugsbayasgalan tugsbayasgalan commented Sep 9, 2024 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135549

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a464a7b with merge base defb515 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62412490

@tugsbayasgalan tugsbayasgalan mentioned this pull request Sep 9, 2024
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62412490

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@yushangdi yushangdi self-requested a review September 10, 2024 00:48
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 10, 2024
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Sep 10, 2024
@tugsbayasgalan @pytorchmergebot
Fix doc (#135551)
5a9ac83 
Differential Revision: [D62412667](https://our.internmc.facebook.com/intern/diff/D62412667/)
Pull Request resolved: #135551
Approved by: https://github.com/yushangdi
ghstack dependencies: #135549
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@tugsbayasgalan @Chao1Han
Add some minor doc improvement and ban using training IR for unflatte…
9009160 
…ner (pytorch#135549)

Title

Differential Revision: [D62412490](https://our.internmc.facebook.com/intern/diff/D62412490/)
Pull Request resolved: pytorch#135549
Approved by: https://github.com/yushangdi
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@tugsbayasgalan @Chao1Han
Fix doc (pytorch#135551)
5f5fa2e 
Differential Revision: [D62412667](https://our.internmc.facebook.com/intern/diff/D62412667/)
Pull Request resolved: pytorch#135551
Approved by: https://github.com/yushangdi
ghstack dependencies: pytorch#135549
@github-actions github-actions bot deleted the gh/tugsbayasgalan/239/head branch October 12, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yushangdi yushangdi yushangdi approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17

@ydwu4 ydwu4 Awaiting requested review from ydwu4

@angelayi angelayi Awaiting requested review from angelayi

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: export

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tugsbayasgalan @facebook-github-bot @pytorchmergebot @yushangdi