Improve performance of canonicalize_bool_expr #135621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135621
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d71d51a with merge base b7eb725 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
reviewed
Sep 11, 2024
| """ | ||
| def integer_coefficient(x): | ||
| if isinstance(x, sympy.Integer): | ||
| if x.is_Integer: |
There was a problem hiding this comment.
It's surprising to me that the attribute test is faster than isinstance; is this because there's some metaclass shenanigans in sympy or something?
There was a problem hiding this comment.
isinstance is slow regardless of metaclass complexity. If you know you have a sympy.Expr, attribute test is faster.
ezyang
reviewed
Sep 11, 2024
| elif isinstance(x, sympy.Mul): | ||
| return math.prod([abs(int(arg)) for arg in x.args if isinstance(arg, sympy.Integer)]) | ||
| elif x.is_Mul: | ||
| return abs(int(x.args[0])) if x.args[0].is_Integer else 1 |
There was a problem hiding this comment.
I guess your point here is that if there are multiple integral factors they're guaranteed to have already been folded
There was a problem hiding this comment.
Yep. Added a comment mentioning this.
ezyang
approved these changes
Sep 11, 2024
This was referenced Sep 11, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 11, 2024
Pull Request resolved: #135622 Approved by: https://github.com/ezyang ghstack dependencies: #135621
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 11, 2024
Pull Request resolved: #135652 Approved by: https://github.com/ezyang ghstack dependencies: #135621, #135622
yushangdi
pushed a commit
that referenced
this pull request
Sep 12, 2024
Pull Request resolved: #135621 Approved by: https://github.com/ezyang
yushangdi
pushed a commit
that referenced
this pull request
Sep 12, 2024
Pull Request resolved: #135622 Approved by: https://github.com/ezyang ghstack dependencies: #135621
yushangdi
pushed a commit
that referenced
this pull request
Sep 12, 2024
Pull Request resolved: #135652 Approved by: https://github.com/ezyang ghstack dependencies: #135621, #135622
tolleybot
pushed a commit
to tolleybot/pytorch
that referenced
this pull request
Sep 14, 2024
Pull Request resolved: pytorch#135621 Approved by: https://github.com/ezyang
tolleybot
pushed a commit
to tolleybot/pytorch
that referenced
this pull request
Sep 14, 2024
Pull Request resolved: pytorch#135622 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#135621
tolleybot
pushed a commit
to tolleybot/pytorch
that referenced
this pull request
Sep 14, 2024
Pull Request resolved: pytorch#135652 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#135621, pytorch#135622
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Pull Request resolved: pytorch#135621 Approved by: https://github.com/ezyang
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Pull Request resolved: pytorch#135622 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#135621
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Pull Request resolved: pytorch#135652 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#135621, pytorch#135622
KnAwnime
pushed a commit
to KnAwnime/Biblioteka
that referenced
this pull request
Oct 16, 2024
ghstack-source-id: b5b800b Pull Request resolved: pytorch/pytorch#135621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):