KEMBAR78
Back out "[pytorch][PR] [export] fix re-export custom metadata" by yiming0416 · Pull Request #135634 · pytorch/pytorch · GitHub
Skip to content

Back out "[pytorch][PR] [export] fix re-export custom metadata" #135634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Back out "[pytorch][PR] [export] fix re-export custom metadata" #135634

wants to merge 1 commit into from

Conversation

@yiming0416
Copy link
Contributor

Summary: Broke some tests. Revert this diff

Test Plan: CI

Differential Revision: D62474337

@yiming0416 @facebook-github-bot
Back out "[pytorch][PR] [export] fix re-export custom metadata"
d3e0a99 
Summary: Broke some tests. Revert this diff

Test Plan: CI

Differential Revision: D62474337
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135634

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit d3e0a99 with merge base e48ee2c (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62474337

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 10, 2024
@yiming0416 yiming0416 mentioned this pull request Sep 11, 2024
Closed
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@yiming0416 @Chao1Han
Back out "[pytorch][PR] [export] fix re-export custom metadata" (pyto…
96f0093 
…rch#135634)

Summary: Broke some tests. Revert this diff

Test Plan: CI

Differential Revision: D62474337

Pull Request resolved: pytorch#135634
Approved by: https://github.com/tugsbayasgalan
@github-actions github-actions bot deleted the export-D62474337 branch October 12, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tugsbayasgalan tugsbayasgalan tugsbayasgalan approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yiming0416 @facebook-github-bot @pytorchmergebot @tugsbayasgalan