KEMBAR78
[CI] [ROCm] Run rocm workflow on every push to main branch by jithunnair-amd · Pull Request #135644 · pytorch/pytorch · GitHub
Skip to content

[CI] [ROCm] Run rocm workflow on every push to main branch #135644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[CI] [ROCm] Run rocm workflow on every push to main branch #135644

wants to merge 2 commits into from

Conversation

@jithunnair-amd
Copy link
Collaborator

@jithunnair-amd jithunnair-amd commented Sep 11, 2024 •
edited by pytorch-bot bot
Loading

@jithunnair-amd jithunnair-amd requested a review from a team as a code owner September 11, 2024 01:05
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135644

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Sep 11, 2024
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 11, 2024
@huydhn
Copy link
Contributor

huydhn commented Sep 11, 2024

@pytorchbot merge -f 'Simple CI update, there are some numpy failures that require rebase to fix but it seems like a waste' -c weird

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 11, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -c weird

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@huydhn
Copy link
Contributor

huydhn commented Sep 11, 2024

@pytorchbot merge -f 'Simple CI update, there are some numpy failures that require rebase to fix but it seems like a waste'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Sep 11, 2024

We should monitor the queue time for ROCM runners and if/when it exceeds say 8 hours, this PR should be reverted...

@jithunnair-amd
Copy link
Collaborator Author

We should monitor the queue time for ROCM runners and if/when it exceeds say 8 hours, this PR should be reverted...

I agree. @amdfaa Please take note.

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@jithunnair-amd @Chao1Han
[CI] [ROCm] Run rocm workflow on every push to main branch (pytorch#1…
d9345ae 
…35644)

Dial the frequency back up from pytorch#131637

Pull Request resolved: pytorch#135644
Approved by: https://github.com/huydhn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@malfet malfet Awaiting requested review from malfet

@atalman atalman Awaiting requested review from atalman

Assignees

No one assigned

Labels

ciflow/rocm Trigger "default" config CI on ROCm Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jithunnair-amd @huydhn @pytorchmergebot @malfet @albanD @pytorchbot