Use a better decomposition for split_with_sizes #135728
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135728
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9cb790e with merge base 356f14e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
reduce instruction count of the following : |
StellarrZ
pushed a commit
to StellarrZ/pytorch
that referenced
this pull request
Sep 15, 2024
…ter decomposition for split_with_sizes (pytorch#135728)" for one test failure (pytorch#136112) Summary: Pull Request resolved: pytorch#136112 This diff reverts D62609535 D62609535: Use a better decomposition for split_with_sizes (pytorch#135728) by generatedunixname499836121 causes the following test failure: Tests affected: - [cogwheel:cogwheel_mtia_adfinder_placement_pruned_test#test_flow_with_verification](https://www.internalfb.com/intern/test/844425044353282/) Here's the Multisect link: https://www.internalfb.com/multisect/10134306 Here are the tasks that are relevant to this breakage: T191383430: 10+ tests unhealthy for ads_mtia_inference The backout may land if someone accepts it. If this diff has been generated in error, you can Commandeer and Abandon it. Test Plan: NA Reviewed By: StellarrZ Differential Revision: D62703865
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
This decomposition has less checks and improves the performance of torch.compile. Pull Request resolved: pytorch#135728 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This decomposition has less checks and improves the performance
of torch.compile.