KEMBAR78
[reland 1/3][fx] Bypass custom __setattr__ in Node.__init__ by jansel · Pull Request #135733 · pytorch/pytorch · GitHub
Skip to content

[reland 1/3][fx] Bypass custom __setattr__ in Node.__init__ #135733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[reland 1/3][fx] Bypass custom __setattr__ in Node.__init__ #135733

wants to merge 1 commit into from

Conversation

@jansel
Copy link
Contributor

@jansel jansel commented Sep 11, 2024

Relands #135079 whcih was reverted by #135562

I broke this up into three parts to test internally.

@jansel
[reland 1/3][fx] Bypass custom __setattr__ in Node.__init__
f5e5d4b 
Relands pytorch#135079 whcih was reverted by pytorch#135562

I broke this up into three parts to test internally.
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135733

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f5e5d4b with merge base 8c738c9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Sep 11, 2024
@facebook-github-bot
Copy link
Contributor

@jansel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jansel jansel requested review from oulgen September 12, 2024 00:24
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@jansel @Chao1Han
[reland 1/3][fx] Bypass custom __setattr__ in Node.__init__ (pytorch#…
d131da3 
…135733)

Relands pytorch#135079 whcih was reverted by pytorch#135562

I broke this up into three parts to test internally.
Pull Request resolved: pytorch#135733
Approved by: https://github.com/oulgen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oulgen oulgen Awaiting requested review from oulgen

Assignees

No one assigned

Labels

Merged release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jansel @facebook-github-bot @pytorchmergebot @oulgen