KEMBAR78
Fix the upload of x86 micro benchmark results by huydhn · Pull Request #135780 · pytorch/pytorch · GitHub
Skip to content

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 12, 2024

Upload stats workflow currently skips this https://github.com/pytorch/pytorch/actions/runs/10807251335/job/29977650639, this is a miss from #135042. So, the workflow is running but nothing has been uploaded yet.

@huydhn huydhn requested a review from yanboliang September 12, 2024 00:53
@huydhn huydhn requested a review from a team as a code owner September 12, 2024 00:53
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135780

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4958253 with merge base d270e2d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 12, 2024
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huydhn
Copy link
Contributor Author

huydhn commented Sep 12, 2024

@pytorchbot merge -f 'Simple CI fix, lint is enough'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn huydhn deleted the fix-inductor-micro-benchmark-x86-upload branch September 13, 2024 21:14
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Upload stats workflow currently skips this https://github.com/pytorch/pytorch/actions/runs/10807251335/job/29977650639, this is a miss from pytorch#135042.  So, the workflow is running but nothing has been uploaded yet.

Pull Request resolved: pytorch#135780
Approved by: https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants