KEMBAR78
[fx] Minor optimization in create_arg by jansel · Pull Request #135821 · pytorch/pytorch · GitHub
Skip to content

[fx] Minor optimization in create_arg #135821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[fx] Minor optimization in create_arg #135821

wants to merge 2 commits into from

Conversation

@jansel
Copy link
Contributor

@jansel jansel commented Sep 12, 2024 •
edited
Loading

@jansel
Update
5c2e2fb 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Sep 12, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135821

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0bc1c3c with merge base 0216936 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Sep 12, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@jansel
Update
0bc1c3c 
[ghstack-poisoned]
@jansel jansel marked this pull request as ready for review September 12, 2024 17:07
@jansel jansel requested a review from oulgen September 12, 2024 17:08
pytorchmergebot pushed a commit that referenced this pull request Sep 13, 2024
@jansel @pytorchmergebot
[fx] Replace _snake_case with a regexp (#135822)
1f15c0c 
~2x speedup on this function, though saves <0.5s overall

Pull Request resolved: #135822
Approved by: https://github.com/oulgen
ghstack dependencies: #135787, #135788, #135820, #135821
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@jansel @Chao1Han
[fx] Minor optimization in create_arg (pytorch#135821)
7699781 
Pull Request resolved: pytorch#135821
Approved by: https://github.com/oulgen
ghstack dependencies: pytorch#135787, pytorch#135788, pytorch#135820
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@jansel @Chao1Han
[fx] Replace _snake_case with a regexp (pytorch#135822)
4a78f2a 
~2x speedup on this function, though saves <0.5s overall

Pull Request resolved: pytorch#135822
Approved by: https://github.com/oulgen
ghstack dependencies: pytorch#135787, pytorch#135788, pytorch#135820, pytorch#135821
@github-actions github-actions bot deleted the gh/jansel/400/head branch October 13, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oulgen oulgen oulgen approved these changes

Assignees

No one assigned

Labels

Merged release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jansel @oulgen @pytorchmergebot