KEMBAR78
Create export_for_inference API and expose core_aten as public facing API by tugsbayasgalan · Pull Request #135912 · pytorch/pytorch · GitHub
Skip to content

Create export_for_inference API and expose core_aten as public facing API #135912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Create export_for_inference API and expose core_aten as public facing API #135912

wants to merge 12 commits into from

Conversation

@tugsbayasgalan
Copy link
Contributor

@tugsbayasgalan tugsbayasgalan commented Sep 12, 2024 •
edited
Loading

@tugsbayasgalan tugsbayasgalan mentioned this pull request Sep 12, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135912

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 76cd8bb with merge base 09519eb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tugsbayasgalan tugsbayasgalan changed the title Create export_for_inference API Create export_for_inference API and expose core_aten as public facing API Sep 12, 2024
avikchaudhuri
avikchaudhuri approved these changes Sep 12, 2024
View reviewed changes
torch/export/__init__.py Outdated
kwargs: Optional[Dict[str, Any]] = None,
*,
dynamic_shapes: Optional[Union[Dict[str, Any], Tuple[Any], List[Any]]] = None,
decomp_table: Optional[Dict["OpOverload", Optional[Callable]]] = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should go last?

torch/export/exported_program.py Outdated

def core_aten_decompositions() -> Dict[torch._ops.OperatorBase, Callable]:
"""
This is an official decomposition table which contains decomposition of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cut official? You can say "default." Or:

This returns a table of decompositions for all aten operators to core aten operators. Use this API...

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 12, 2024
@tugsbayasgalan tugsbayasgalan mentioned this pull request Sep 12, 2024
Closed
@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tugsbayasgalan
Copy link
Contributor Author

@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Sep 15, 2024
@tugsbayasgalan @pytorchmergebot
Add some doc for export_for_training (#135918)
dec3403 
Differential Revision: [D62610491](https://our.internmc.facebook.com/intern/diff/D62610491)
Pull Request resolved: #135918
Approved by: https://github.com/avikchaudhuri
ghstack dependencies: #135080, #135912
@tugsbayasgalan tugsbayasgalan mentioned this pull request Sep 17, 2024
Closed
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@tugsbayasgalan @Chao1Han
Create export_for_inference API and expose core_aten as public facing…
af41162 
… API (pytorch#135912)

Differential Revision: [D62606908](https://our.internmc.facebook.com/intern/diff/D62606908)
Pull Request resolved: pytorch#135912
Approved by: https://github.com/avikchaudhuri
ghstack dependencies: pytorch#135080
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@tugsbayasgalan @Chao1Han
Add some doc for export_for_training (pytorch#135918)
c87301c 
Differential Revision: [D62610491](https://our.internmc.facebook.com/intern/diff/D62610491)
Pull Request resolved: pytorch#135918
Approved by: https://github.com/avikchaudhuri
ghstack dependencies: pytorch#135080, pytorch#135912
@github-actions github-actions bot deleted the gh/tugsbayasgalan/241/head branch October 16, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avikchaudhuri avikchaudhuri avikchaudhuri approved these changes

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17

@ydwu4 ydwu4 Awaiting requested review from ydwu4

@angelayi angelayi Awaiting requested review from angelayi

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: export

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tugsbayasgalan @facebook-github-bot @pytorchmergebot @avikchaudhuri