KEMBAR78
passing FileTimerRequests.to_json() to log_debug_info_for_expired_timers for a better debugging experience by felixsu2006 · Pull Request #135913 · pytorch/pytorch · GitHub
Skip to content

passing FileTimerRequests.to_json() to log_debug_info_for_expired_timers for a better debugging experience #135913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

passing FileTimerRequests.to_json() to log_debug_info_for_expired_timers for a better debugging experience #135913

wants to merge 1 commit into from

Conversation

@felixsu2006
Copy link
Contributor

@felixsu2006 felixsu2006 commented Sep 12, 2024 •
edited by pytorch-bot bot
Loading

Summary: The change involves passing the expired timers to the log_debug_info_for_expired_timers function after to_json() has been applied . This change is made to provide a better debugging experience for the user.

Test Plan: unit tests

Reviewed By: gag1jain

Differential Revision: D62408767

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2024

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @felixsu2006, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 12, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (torchelastic) labels Sep 12, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135913

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit f770f8f with merge base 172ecf7 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62408767

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62408767

felixsu2006 added a commit to felixsu2006/pytorch that referenced this pull request Sep 17, 2024
@felixsu2006 @facebook-github-bot
passing FileTimerRequests.to_json() to log_debug_info_for_expired_tim…
660d70d 
…ers for a better debugging experience (pytorch#135913)

Summary:
Pull Request resolved: pytorch#135913

The change involves passing the expired timers to the log_debug_info_for_expired_timers function after to_json() has been applied . This change is made to provide a better debugging experience for the user.

Test Plan: unit tests

Reviewed By: gag1jain

Differential Revision: D62408767
@gag1jain gag1jain self-requested a review September 17, 2024 22:35
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 17, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62408767

@felixsu2006 @facebook-github-bot
passing FileTimerRequests.to_json() to log_debug_info_for_expired_tim…
f770f8f 
…ers for a better debugging experience (pytorch#135913)

Summary:
Pull Request resolved: pytorch#135913

The change involves passing the expired timers to the log_debug_info_for_expired_timers function after to_json() has been applied . This change is made to provide a better debugging experience for the user.

Test Plan: unit tests

Reviewed By: gag1jain

Differential Revision: D62408767
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62408767

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@felixsu2006 @Chao1Han
passing FileTimerRequests.to_json() to log_debug_info_for_expired_tim…
c9d6bb8 
…ers for a better debugging experience (pytorch#135913)

Summary: The change involves passing the expired timers to the log_debug_info_for_expired_timers function after to_json() has been applied . This change is made to provide a better debugging experience for the user.

Test Plan: unit tests

Reviewed By: gag1jain

Differential Revision: D62408767

Pull Request resolved: pytorch#135913
Approved by: https://github.com/gag1jain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gag1jain gag1jain gag1jain approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (torchelastic)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felixsu2006 @facebook-github-bot @pytorchmergebot @gag1jain