KEMBAR78
[AOTI] Fix a fallback op returning None issue by desertfire · Pull Request #135997 · pytorch/pytorch · GitHub
Skip to content

[AOTI] Fix a fallback op returning None issue #135997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[AOTI] Fix a fallback op returning None issue #135997

wants to merge 2 commits into from

Conversation

@desertfire
Copy link
Contributor

@desertfire desertfire commented Sep 13, 2024 •
edited
Loading

@desertfire
[AOTI] Fix a fallback op returning None
043e644 
Summary: Fixes #135781. In some cases, a fallback can return None in the place of a tensor.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135997

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fcaf8e3 with merge base 21ffa18 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@desertfire desertfire added the topic: not user facing topic category label Sep 13, 2024
@desertfire
Update on "[AOTI] Fix a fallback op returning None"
fcaf8e3 
Summary: Fixes #135781. In some cases, a fallback can return None in the place of a tensor.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Sep 13, 2024
@desertfire
[AOTI] Fix a fallback op returning None
577c37a 
Summary: Fixes #135781. In some cases, a fallback can return None in the place of a tensor.

ghstack-source-id: 5f2cef3
Pull Request resolved: #135997
@desertfire
Copy link
Contributor Author

@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@desertfire desertfire changed the title [AOTI] Fix a fallback op returning None [AOTI] Fix a fallback op returning None issue Sep 13, 2024
chenyang78
chenyang78 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@chenyang78 chenyang78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 13, 2024
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@desertfire @Chao1Han
[AOTI] Fix a fallback op returning None issue (pytorch#135997)
7380d47 
Summary: Fixes pytorch#135781. In some cases, a fallback can return None in the place of a tensor.

Differential Revision: [D62659039](https://our.internmc.facebook.com/intern/diff/D62659039)
Pull Request resolved: pytorch#135997
Approved by: https://github.com/chenyang78
@github-actions github-actions bot deleted the gh/desertfire/461/head branch October 15, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyang78 chenyang78 chenyang78 approved these changes

@angelayi angelayi Awaiting requested review from angelayi

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@desertfire @facebook-github-bot @pytorchmergebot @chenyang78