Fix bug in split-build workflows codegen #136043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136043
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1c01fc4 with merge base 2e461e5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kit1980
approved these changes
Sep 13, 2024
By just deleting a few rogue lines left out in #135510 If file in workflows folder does not have a `.yml` extensions it will not be launched at all, will it?
malfet
force-pushed
the
malfet/fix-bug-in-split-build-name-gen
branch
from
7b94f2d to
1c01fc4
Compare
|
@pytorchbot merge -f "Lint is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
By just deleting a few rogue lines left out in pytorch#135510 If file in workflows folder does not have a `.yml` extensions it will not be launched at all, will it? Pull Request resolved: pytorch#136043 Approved by: https://github.com/kit1980, https://github.com/atalman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By just deleting a few rogue lines left out in #135510
If file in workflows folder does not have a
.ymlextensions it will not be launched at all, will it?