KEMBAR78
Fix inductor-micro-benchmark results upload (take 2) by huydhn · Pull Request #136052 · pytorch/pytorch · GitHub
Skip to content

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 13, 2024

I had a brain freeze when I wrote the original fix. The parameters were in the wrong order.

@huydhn huydhn requested a review from atalman September 13, 2024 21:16
@huydhn huydhn requested a review from a team as a code owner September 13, 2024 21:16
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 13, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136052

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 83ff70f with merge base 2e461e5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn
Copy link
Contributor Author

huydhn commented Sep 13, 2024

@pytorchbot merge -f 'Tiny CI fix, just need lint'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
I had a brain freeze when I wrote the original fix.  The parameters were in the wrong order.
Pull Request resolved: pytorch#136052
Approved by: https://github.com/clee2000, https://github.com/kit1980, https://github.com/malfet
@huydhn huydhn deleted the fix-inductor-micro-benchmark-x86-upload-again branch November 14, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants