KEMBAR78
[CI] Increase open file handles limit to 16K on MacOS by malfet · Pull Request #136061 · pytorch/pytorch · GitHub
Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Sep 13, 2024

May be it will help with flaky failures tracked in #135885

May be it will help with flaky failures tracked in #135885
@malfet malfet requested a review from a team as a code owner September 13, 2024 23:03
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136061

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 2577c0c with merge base b8eef50 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 13, 2024
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What might a safe maximum limit here be? Is there any reason to not bump this even higher?

@malfet malfet added the topic: not user facing topic category label Sep 14, 2024
@malfet
Copy link
Contributor Author

malfet commented Sep 14, 2024

@pytorchbot merge

@malfet
Copy link
Contributor Author

malfet commented Sep 14, 2024

What might a safe maximum limit here be? Is there any reason to not bump this even higher?

One can make it higher, but it becomes a bit unreasonable, because if process exceeds 16K open file handles, than there is likely a leak somewhere

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@github-actions github-actions bot deleted the malfet-patch-21 branch October 14, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants