-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[CI] Increase open file handles limit to 16K on MacOS #136061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
May be it will help with flaky failures tracked in #135885
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136061
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 2577c0c with merge base b8eef50 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What might a safe maximum limit here be? Is there any reason to not bump this even higher?
|
@pytorchbot merge |
One can make it higher, but it becomes a bit unreasonable, because if process exceeds 16K open file handles, than there is likely a leak somewhere |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
May be it will help with flaky failures tracked in pytorch#135885 Pull Request resolved: pytorch#136061 Approved by: https://github.com/clee2000, https://github.com/kit1980, https://github.com/huydhn, https://github.com/ZainRizvi
May be it will help with flaky failures tracked in #135885