Fix dividing Mul by factor #136079
Closed
Fix dividing Mul by factor #136079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136079
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fe73be3 with merge base a157745 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
approved these changes
Sep 14, 2024
|
Did you figure out how to repro this haha |
|
No, I couldn't figure out a repro. Hopefully this fixes the issue. |
|
testin it |
|
Confirmed works. Actually I wonder if there is a sympy version divergence needed to trigger this in fbcode; we appear to be 1.12, I think?? |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Fixes pytorch#136032 Pull Request resolved: pytorch#136079 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #136032