KEMBAR78
Tune bsr_dense_addmm for int8 inputs on A100 by pearu · Pull Request #136088 · pytorch/pytorch · GitHub
Skip to content

Tune bsr_dense_addmm for int8 inputs on A100 #136088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Tune bsr_dense_addmm for int8 inputs on A100 #136088

wants to merge 6 commits into from

Conversation

@pearu
Copy link
Collaborator

@pearu pearu commented Sep 14, 2024 •
edited
Loading

As in the title. The tuning is done for dimensions 1280 and 5120 that are used in Vit-H.

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136088

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 4908579 with merge base 0b667c0 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added release notes: sparse release notes category labels Sep 14, 2024
@pearu
Update on "Tune bsr_dense_addmm for int8 inputs on A100"
aa75fe1 
As in the title. The tuning is done for dimensions 1280 and 5120 that are used in Vit-H.




[ghstack-poisoned]
@pearu
Update on "Tune bsr_dense_addmm for int8 inputs on A100"
81da866 
As in the title. The tuning is done for dimensions 1280 and 5120 that are used in Vit-H.




[ghstack-poisoned]
@pearu
Update on "Tune bsr_dense_addmm for int8 inputs on A100"
b202aa9 
As in the title. The tuning is done for dimensions 1280 and 5120 that are used in Vit-H.




[ghstack-poisoned]
pearu added a commit that referenced this pull request Sep 14, 2024
@pearu
Tune bsr_dense_addmm for int8 inputs on A100
fb2b34a 
ghstack-source-id: 5d2edc1
Pull Request resolved: #136088
@pearu pearu requested review from amjames and cpuhrsch September 15, 2024 17:37
@pearu pearu added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 15, 2024
@pearu
Copy link
Collaborator Author

pearu commented Sep 16, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x fb2b34a280436c4524298543b864ab817d095739 returned non-zero exit code 1

Auto-merging torch/sparse/_triton_ops.py
CONFLICT (content): Merge conflict in torch/sparse/_triton_ops.py
Auto-merging torch/sparse/_triton_ops_meta.py
error: could not apply fb2b34a280... Tune bsr_dense_addmm for int8 inputs on A100
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@pearu
Update on "Tune bsr_dense_addmm for int8 inputs on A100"
247802b 
As in the title. The tuning is done for dimensions 1280 and 5120 that are used in Vit-H.




[ghstack-poisoned]
pearu added a commit that referenced this pull request Sep 16, 2024
@pearu
Tune bsr_dense_addmm for int8 inputs on A100
eb205da 
ghstack-source-id: f03702c
Pull Request resolved: #136088
@pearu
Copy link
Collaborator Author

pearu commented Sep 17, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#136192

Details for Dev Infra team Raised by workflow job

@amjames
Copy link
Collaborator

amjames commented Sep 24, 2024

sev label has been removed from the issue that blocked merge so I'm going to rebase and retry.

@amjames
Copy link
Collaborator

amjames commented Sep 24, 2024

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pearu
Update
4908579 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/pearu/134/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/136088)

pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2024
@pearu
Tune bsr_dense_addmm for int8 inputs on A100
430ecb1 
ghstack-source-id: 2ed846f
Pull Request resolved: #136088
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
@pearu @BoyuanFeng
Tune bsr_dense_addmm for int8 inputs on A100 (pytorch#136088)
c5b87d0 
As in the title. The tuning is done for dimensions 1280 and 5120 that are used in Vit-H.

Pull Request resolved: pytorch#136088
Approved by: https://github.com/cpuhrsch
@github-actions github-actions bot deleted the gh/pearu/134/head branch October 25, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@amjames amjames Awaiting requested review from amjames

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: sparse release notes category topic: not user facing topic category topic: performance topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pearu @pytorchmergebot @amjames @cpuhrsch