[ONNX] Unify ONNXProgram and remove the old one #136281

justinchuby · 2024-09-18T17:56:06Z

Stack from ghstack (oldest at bottom):

Note

test_fx_to_onnx_with_onnxruntime.py is removed for now (it has a lot of xfails anyways). A better version will be added back.

Fixes #136274

cc @albanD

[ghstack-poisoned]

pytorch-bot · 2024-09-18T17:56:10Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136281

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 395c9dc with merge base 9abdc62 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: d5ae885 Pull Request resolved: #136281

Fixes #136274 [ghstack-poisoned]

ghstack-source-id: 7a72fba Pull Request resolved: pytorch#136281

Fixes #136274 [ghstack-poisoned]

ghstack-source-id: ff06bcb Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

Fixes #136274 [ghstack-poisoned]

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now. A better version will be added back. Fixes #136274 [ghstack-poisoned]

ghstack-source-id: ada375f Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

## TODO - Make sure onnxprogram is importable w/o onnxscript - Update fx tests ## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now. A better version will be added back. Fixes #136274 [ghstack-poisoned]

ghstack-source-id: 5a72b1e Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

## TODO - Make sure onnxprogram is importable w/o onnxscript - Update fx tests ## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now. A better version will be added back. Fixes #136274 [ghstack-poisoned]

ghstack-source-id: 1852d59 Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

## TODO - Make sure onnxprogram is importable w/o onnxscript - Update fx tests ## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now. A better version will be added back. Fixes #136274 [ghstack-poisoned]

ghstack-source-id: 0e4c585 Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

## TODO - Make sure onnxprogram is importable w/o onnxscript - Update fx tests ## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now. A better version will be added back. Fixes #136274 [ghstack-poisoned]

ghstack-source-id: 94d4280 Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now (it has a lot of xfails anyways). A better version will be added back. Fixes #136274 [ghstack-poisoned]

ghstack-source-id: dd50af4 Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

albanD

Skipping PR sanity check for code removal sounds good!
Thanks for the cleanup!

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now (it has a lot of xfails anyways). A better version will be added back. Fixes #136274 cc albanD [ghstack-poisoned]

ghstack-source-id: cd9428a Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now (it has a lot of xfails anyways). A better version will be added back. Fixes #136274 cc albanD [ghstack-poisoned]

ghstack-source-id: f6bca05 Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now (it has a lot of xfails anyways). A better version will be added back. Fixes #136274 cc albanD [ghstack-poisoned]

ghstack-source-id: e4e7f81 Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

justinchuby · 2024-09-24T19:41:24Z

@pytorchbot merge

pytorchmergebot · 2024-09-24T19:43:21Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

justinchuby · 2024-09-24T20:50:23Z

@pytorchbot merge -f "All relevant tests passed"

pytorchmergebot · 2024-09-24T20:50:43Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

pytorchmergebot · 2024-09-24T20:52:09Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Pull Request resolved: #136279 Approved by: https://github.com/xadupre ghstack dependencies: #136281

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now (it has a lot of xfails anyways). A better version will be added back. Fixes pytorch#136274 Pull Request resolved: pytorch#136281 Approved by: https://github.com/xadupre, https://github.com/albanD

Pull Request resolved: pytorch#136279 Approved by: https://github.com/xadupre ghstack dependencies: pytorch#136281

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now (it has a lot of xfails anyways). A better version will be added back. Fixes pytorch#136274 Pull Request resolved: pytorch#136281 Approved by: https://github.com/xadupre, https://github.com/albanD

Pull Request resolved: pytorch#136279 Approved by: https://github.com/xadupre ghstack dependencies: pytorch#136281

titaiwangms · 2024-12-18T19:26:54Z

torch/onnx/_internal/_exporter_legacy.py

-                self.options.diagnostic_context,
-                fake_context=self.options.fake_context,
-                model_torch=self.model,
+            return _onnx_program.ONNXProgram(


@justinchuby How do we call io_adapter in this scenario?

[ONNX] Unify ONNXProgram and remove the old one

854fcb1

[ghstack-poisoned]

justinchuby requested review from shubhambhokare1, titaiwangms and wschin as code owners September 18, 2024 17:56

This was referenced Sep 18, 2024

[ONNX] Remove deprecated OperatorExportTypes and ExportTypes #136277

Closed

[ONNX] Remove _optimize_graph from public init #136279

Closed

pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Sep 18, 2024

justinchuby added a commit that referenced this pull request Sep 18, 2024

[ONNX] Unify ONNXProgram and remove the old one

8a704c1

ghstack-source-id: d5ae885 Pull Request resolved: #136281

Update on "[ONNX] Unify ONNXProgram and remove the old one"

7ac2a1b

Fixes #136274 [ghstack-poisoned]

justinchuby added module: onnx Related to torch.onnx suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) labels Sep 18, 2024

pytorchbot added the open source label Sep 18, 2024

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 18, 2024

[ONNX] Unify ONNXProgram and remove the old one

eae85e2

ghstack-source-id: 7a72fba Pull Request resolved: pytorch#136281

Update on "[ONNX] Unify ONNXProgram and remove the old one"

4f345b5

Fixes #136274 [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 18, 2024

[ONNX] Unify ONNXProgram and remove the old one

1807880

ghstack-source-id: ff06bcb Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

Update on "[ONNX] Unify ONNXProgram and remove the old one"

a457c22

Fixes #136274 [ghstack-poisoned]

justinchuby added the topic: bc breaking topic category label Sep 18, 2024

Update on "[ONNX] Unify ONNXProgram and remove the old one"

0f5406d

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now. A better version will be added back. Fixes #136274 [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 18, 2024

[ONNX] Unify ONNXProgram and remove the old one

d33fa26

ghstack-source-id: ada375f Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

Update on "[ONNX] Unify ONNXProgram and remove the old one"

efb605f

## TODO - Make sure onnxprogram is importable w/o onnxscript - Update fx tests ## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now. A better version will be added back. Fixes #136274 [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 19, 2024

[ONNX] Unify ONNXProgram and remove the old one

2042cea

ghstack-source-id: 5a72b1e Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

Update on "[ONNX] Unify ONNXProgram and remove the old one"

96fd0b8

## TODO - Make sure onnxprogram is importable w/o onnxscript - Update fx tests ## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now. A better version will be added back. Fixes #136274 [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 19, 2024

[ONNX] Unify ONNXProgram and remove the old one

1fabd25

ghstack-source-id: 1852d59 Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

Update on "[ONNX] Unify ONNXProgram and remove the old one"

f0cfcbb

## TODO - Make sure onnxprogram is importable w/o onnxscript - Update fx tests ## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now. A better version will be added back. Fixes #136274 [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 19, 2024

[ONNX] Unify ONNXProgram and remove the old one

58cb0b2

ghstack-source-id: 0e4c585 Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

Update on "[ONNX] Unify ONNXProgram and remove the old one"

2906bbe

## TODO - Make sure onnxprogram is importable w/o onnxscript - Update fx tests ## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now. A better version will be added back. Fixes #136274 [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 19, 2024

[ONNX] Unify ONNXProgram and remove the old one

ecbaac7

ghstack-source-id: 94d4280 Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

justinchuby mentioned this pull request Sep 19, 2024

[ONNX] Remove the operators test #136335

Closed

xadupre approved these changes Sep 19, 2024

View reviewed changes

pytorchmergebot removed the merging label Sep 23, 2024

Update on "[ONNX] Unify ONNXProgram and remove the old one"

64509b4

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now (it has a lot of xfails anyways). A better version will be added back. Fixes #136274 [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 23, 2024

[ONNX] Unify ONNXProgram and remove the old one

f35bde9

ghstack-source-id: dd50af4 Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

justinchuby added the skip-pr-sanity-checks label Sep 23, 2024

albanD approved these changes Sep 24, 2024

View reviewed changes

Update on "[ONNX] Unify ONNXProgram and remove the old one"

3fc1ba0

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now (it has a lot of xfails anyways). A better version will be added back. Fixes #136274 cc albanD [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 24, 2024

[ONNX] Unify ONNXProgram and remove the old one

bba9252

ghstack-source-id: cd9428a Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

justinchuby added 2 commits September 24, 2024 11:08

Update on "[ONNX] Unify ONNXProgram and remove the old one"

933ef80

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now (it has a lot of xfails anyways). A better version will be added back. Fixes #136274 cc albanD [ghstack-poisoned]

Update on "[ONNX] Unify ONNXProgram and remove the old one"

cbf6536

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now (it has a lot of xfails anyways). A better version will be added back. Fixes #136274 cc albanD [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 24, 2024

[ONNX] Unify ONNXProgram and remove the old one

26f55ba

ghstack-source-id: f6bca05 Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

justinchuby added 2 commits September 24, 2024 11:42

Update on "[ONNX] Unify ONNXProgram and remove the old one"

6b4f8f2

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now (it has a lot of xfails anyways). A better version will be added back. Fixes #136274 cc albanD [ghstack-poisoned]

Update on "[ONNX] Unify ONNXProgram and remove the old one"

395c9dc

## Note `test_fx_to_onnx_with_onnxruntime.py` is removed for now (it has a lot of xfails anyways). A better version will be added back. Fixes #136274 cc albanD [ghstack-poisoned]

justinchuby added a commit to justinchuby/pytorch that referenced this pull request Sep 24, 2024

[ONNX] Unify ONNXProgram and remove the old one

3230261

ghstack-source-id: e4e7f81 Pull Request resolved: pytorch#136281 Signed-off-by: Justin Chu <justinchu@microsoft.com>

pytorchmergebot added the merging label Sep 24, 2024

pytorchmergebot added the Merged label Sep 24, 2024

pytorchmergebot closed this in 7c777dd Sep 24, 2024

pytorchmergebot removed the merging label Sep 24, 2024

pytorchmergebot pushed a commit that referenced this pull request Sep 24, 2024

[ONNX] Remove _optimize_graph from public init (#136279)

780f4de

Pull Request resolved: #136279 Approved by: https://github.com/xadupre ghstack dependencies: #136281

PaliC pushed a commit to PaliC/pytorch that referenced this pull request Sep 25, 2024

[ONNX] Remove _optimize_graph from public init (pytorch#136279)

08c5fc1

Pull Request resolved: pytorch#136279 Approved by: https://github.com/xadupre ghstack dependencies: pytorch#136281

BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024

[ONNX] Remove _optimize_graph from public init (pytorch#136279)

e80c885

Pull Request resolved: pytorch#136279 Approved by: https://github.com/xadupre ghstack dependencies: pytorch#136281

github-actions bot deleted the gh/justinchuby/103/head branch October 25, 2024 02:10

titaiwangms reviewed Dec 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ONNX] Unify ONNXProgram and remove the old one #136281

[ONNX] Unify ONNXProgram and remove the old one #136281

Uh oh!

justinchuby commented Sep 18, 2024 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Sep 18, 2024 •

edited

Loading

Uh oh!

albanD left a comment

Uh oh!

justinchuby commented Sep 24, 2024

Uh oh!

pytorchmergebot commented Sep 24, 2024

Uh oh!

justinchuby commented Sep 24, 2024

Uh oh!

pytorchmergebot commented Sep 24, 2024

Uh oh!

pytorchmergebot commented Sep 24, 2024

Uh oh!

titaiwangms Dec 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[ONNX] Unify ONNXProgram and remove the old one #136281

[ONNX] Unify ONNXProgram and remove the old one #136281

Uh oh!

Conversation

justinchuby commented Sep 18, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Note

Uh oh!

pytorch-bot bot commented Sep 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136281

✅ No Failures

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

justinchuby commented Sep 24, 2024

Uh oh!

pytorchmergebot commented Sep 24, 2024

Merge started

Uh oh!

justinchuby commented Sep 24, 2024

Uh oh!

pytorchmergebot commented Sep 24, 2024

Uh oh!

pytorchmergebot commented Sep 24, 2024

Merge started

Uh oh!

titaiwangms Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

justinchuby commented Sep 18, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Sep 18, 2024 •

edited

Loading