[QAT] Make Fused modules torchscriptable #136285

Ninja91 · 2024-09-18T19:48:56Z

Summary:
Same as title.

Inspired by: https://pytorch.org/tutorials/recipes/script_optimized.html#fix-common-errors-when-using-the-script-method

Test Plan: CI

Differential Revision: D62980019

pytorch-bot · 2024-09-18T19:48:59Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136285

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 92e4eb3 with merge base e4571e7 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-09-18T19:49:11Z

This pull request was exported from Phabricator. Differential Revision: D62980019

jerryzh168 · 2024-09-26T17:27:12Z

still not in sync I think

facebook-github-bot · 2024-09-26T17:28:15Z

This pull request was exported from Phabricator. Differential Revision: D62980019

Summary: Pull Request resolved: #136285 Same as title. Just moved around code to avoid torchscript failing on - False branch not having `conv_output` variable - type inference issue Inspired by: https://pytorch.org/tutorials/recipes/script_optimized.html#fix-common-errors-when-using-the-script-method Test Plan: CI Reviewed By: jerryzh168 Differential Revision: D62980019

Ninja91 · 2024-09-26T17:56:18Z

@pytorchbot merge

pytorchmergebot · 2024-09-26T17:58:03Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-26T22:55:21Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

Summary: Pull Request resolved: pytorch#136285 Same as title. Just moved around code to avoid torchscript failing on - False branch not having `conv_output` variable - type inference issue Inspired by: https://pytorch.org/tutorials/recipes/script_optimized.html#fix-common-errors-when-using-the-script-method Test Plan: CI Reviewed By: jerryzh168 Differential Revision: D62980019

facebook-github-bot · 2024-09-27T05:01:45Z

This pull request was exported from Phabricator. Differential Revision: D62980019

facebook-github-bot · 2024-09-27T20:34:56Z

This pull request was exported from Phabricator. Differential Revision: D62980019

facebook-github-bot · 2024-09-27T20:38:35Z

This pull request was exported from Phabricator. Differential Revision: D62980019

facebook-github-bot · 2024-09-27T21:12:59Z

This pull request was exported from Phabricator. Differential Revision: D62980019

Ninja91 · 2024-09-27T21:14:53Z

@pytorchbot merge

facebook-github-bot · 2024-09-27T21:43:03Z

This pull request was exported from Phabricator. Differential Revision: D62980019

Ninja91 · 2024-09-27T21:47:42Z

@pytorchbot merge

pytorchmergebot · 2024-09-27T21:49:28Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-09-27T22:15:12Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

facebook-github-bot · 2024-09-27T22:22:39Z

This pull request was exported from Phabricator. Differential Revision: D62980019

facebook-github-bot · 2024-09-27T22:57:28Z

This pull request was exported from Phabricator. Differential Revision: D62980019

facebook-github-bot · 2024-09-28T00:54:04Z

This pull request was exported from Phabricator. Differential Revision: D62980019

Ninja91 · 2024-09-28T00:58:27Z

@pytorchbot merge

Summary: Pull Request resolved: pytorch#136285 Same as title. Just moved around code to avoid torchscript failing on - False branch not having `conv_output` variable - type inference issue Inspired by: https://pytorch.org/tutorials/recipes/script_optimized.html#fix-common-errors-when-using-the-script-method Test Plan: CI Reviewed By: jerryzh168 Differential Revision: D62980019

pytorchmergebot · 2024-09-28T01:00:12Z

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team

Raised by workflow job

facebook-github-bot · 2024-09-28T01:20:05Z

This pull request was exported from Phabricator. Differential Revision: D62980019

facebook-github-bot · 2024-09-28T03:44:38Z

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

pytorchmergebot · 2024-09-28T03:46:13Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorch-bot bot added the release notes: AO frontend label Sep 18, 2024

facebook-github-bot added the fb-exported label Sep 18, 2024

Ninja91 requested a review from jerryzh168 September 18, 2024 21:21

jerryzh168 approved these changes Sep 26, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 26, 2024

Ninja91 force-pushed the export-D62980019 branch from 9561974 to ce05887 Compare September 26, 2024 17:28

pytorch-bot bot added the release notes: quantization release notes category label Sep 26, 2024

pytorchmergebot added the merging label Sep 26, 2024

pytorchmergebot removed the merging label Sep 26, 2024

Ninja91 force-pushed the export-D62980019 branch from ce05887 to 9174c1a Compare September 27, 2024 05:01

Ninja91 force-pushed the export-D62980019 branch from 9174c1a to 153324c Compare September 27, 2024 19:22

Ninja91 force-pushed the export-D62980019 branch from 153324c to c20a6b8 Compare September 27, 2024 19:27

Ninja91 force-pushed the export-D62980019 branch from c20a6b8 to 39c86b2 Compare September 27, 2024 21:13

Ninja91 force-pushed the export-D62980019 branch from e8bb3ba to 4974257 Compare September 27, 2024 21:33

Ninja91 force-pushed the export-D62980019 branch from 4974257 to 469654d Compare September 27, 2024 21:43

Ninja91 force-pushed the export-D62980019 branch from 469654d to c92885f Compare September 27, 2024 21:49

pytorchmergebot added the merging label Sep 27, 2024

pytorchmergebot removed the merging label Sep 27, 2024

Ninja91 force-pushed the export-D62980019 branch from c92885f to 86a28d0 Compare September 28, 2024 00:54

pytorchmergebot added the merging label Sep 28, 2024

pytorchmergebot removed the merging label Sep 28, 2024

Ninja91 force-pushed the export-D62980019 branch from 86a28d0 to 92e4eb3 Compare September 28, 2024 01:01

pytorchmergebot added the merging label Sep 28, 2024

pytorchmergebot added the Merged label Sep 28, 2024

pytorchmergebot closed this in 8df97d7 Sep 28, 2024

pytorchmergebot removed the merging label Sep 28, 2024

[QAT] Make Fused modules torchscriptable #136285

[QAT] Make Fused modules torchscriptable #136285

Uh oh!

Conversation

Ninja91 commented Sep 18, 2024

Uh oh!

pytorch-bot bot commented Sep 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136285

✅ No Failures

Uh oh!

facebook-github-bot commented Sep 18, 2024

Uh oh!

jerryzh168 commented Sep 26, 2024

Uh oh!

facebook-github-bot commented Sep 26, 2024

Uh oh!

Ninja91 commented Sep 26, 2024

Uh oh!

pytorchmergebot commented Sep 26, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 26, 2024

Merge failed

Uh oh!

facebook-github-bot commented Sep 27, 2024

Uh oh!

facebook-github-bot commented Sep 27, 2024

Uh oh!

facebook-github-bot commented Sep 27, 2024

Uh oh!

facebook-github-bot commented Sep 27, 2024

Uh oh!

Ninja91 commented Sep 27, 2024

Uh oh!

facebook-github-bot commented Sep 27, 2024

Uh oh!

Ninja91 commented Sep 27, 2024

Uh oh!

pytorchmergebot commented Sep 27, 2024

Merge started

Uh oh!

pytorchmergebot commented Sep 27, 2024

Merge failed

Uh oh!

facebook-github-bot commented Sep 27, 2024

Uh oh!

facebook-github-bot commented Sep 27, 2024

Uh oh!

facebook-github-bot commented Sep 28, 2024

Uh oh!

Ninja91 commented Sep 28, 2024

Uh oh!

pytorchmergebot commented Sep 28, 2024

Merge failed

Uh oh!

facebook-github-bot commented Sep 28, 2024

Uh oh!

facebook-github-bot commented Sep 28, 2024

Uh oh!

pytorchmergebot commented Sep 28, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pytorch-bot bot commented Sep 18, 2024 •

edited

Loading