Remove onnx imports in dynamo #136334
Closed
Remove onnx imports in dynamo #136334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136334
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (13 Unrelated Failures)As of commit d9f29d3 with merge base 68a7246 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
xadupre
approved these changes
Sep 19, 2024
jansel
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Looks like tests are failing, you might be able to handle this similar to https://github.com/pytorch/pytorch/blob/main/torch/_dynamo/trace_rules.py
justinchuby
requested review from
shubhambhokare1,
titaiwangms and
wschin
as code owners
justinchuby
added
the
suppress-bc-linter
|
@jansel I fixed it by changing the functions to alias the aten ops. Please take another look. Thanks. |
xadupre
approved these changes
Sep 23, 2024
|
@pytorchbot merge -i |
Merge failedReason: Approvers from one of the following sets are needed:
|
titaiwangms
approved these changes
Sep 23, 2024
soulitzer
added
the
triaged
jansel
approved these changes
Sep 24, 2024
|
@pytorchbot merge -i |
|
@pytorchbot merge -f "flaky tests" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
skotapati
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Sep 24, 2024
Remove imports of the ``torch.onnx.operators`` module in dynamo. Since ONNX depends on dynamo, this import line causes a circular dependency. Judging from the source they are not actually needed. Pull Request resolved: pytorch#136334 Approved by: https://github.com/xadupre, https://github.com/jansel, https://github.com/titaiwangms
BoyuanFeng
pushed a commit
to BoyuanFeng/pytorch
that referenced
this pull request
Sep 25, 2024
Remove imports of the ``torch.onnx.operators`` module in dynamo. Since ONNX depends on dynamo, this import line causes a circular dependency. Judging from the source they are not actually needed. Pull Request resolved: pytorch#136334 Approved by: https://github.com/xadupre, https://github.com/jansel, https://github.com/titaiwangms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove imports of the
torch.onnx.operatorsmodule in dynamo. Since ONNX depends on dynamo, this import line causes a circular dependency. Judging from the source they are not actually needed.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @rec @xadupre @gramalingam @titaiwangms