Use amazon linux 2023 runners for Docker builds #136544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136544
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit be8ec13 with merge base eac04fe ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ZainRizvi
previously approved these changes
Sep 24, 2024
ZainRizvi
dismissed
their stale review
dismissing until the docker builds actually work
malfet
reviewed
Sep 25, 2024
atalman
force-pushed
the
use_amazon2_docker
branch
from
b0ba475 to
6863c4c
Compare
atalman
force-pushed
the
use_amazon2_docker
branch
from
537d542 to
e618fc4
Compare
ZainRizvi
reviewed
Sep 25, 2024
.ci/docker/conda/Dockerfile
Outdated
malfet
reviewed
Sep 25, 2024
ZainRizvi
approved these changes
Sep 25, 2024
|
@pytorchbot merge -f "Lint is green, let's test it in prod..." |
ZainRizvi
approved these changes
Sep 25, 2024
| set -x | ||
| # TODO: Remove LimitNOFILE=1048576 patch once https://github.com/pytorch/test-infra/issues/5712 | ||
| # is resolved. This patch is required in order to fix timing out of Docker build on Amazon Linux 2023. | ||
| sudo sed -i s/LimitNOFILE=infinity/LimitNOFILE=1048576/ /usr/lib/systemd/system/docker.service |
There was a problem hiding this comment.
nit: please add a link to the issue that you discovered which explains the problem in more detail
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
BoyuanFeng
pushed a commit
to BoyuanFeng/pytorch
that referenced
this pull request
Sep 25, 2024
Migrate these builds to linux 2023. We want to build and test the Docker images in CD. Looks like we are hitting this issue: docker/buildx#379 when trying to build Docker on Amazon Linux 2023. Conda Docker build is timing out. While Manywheel is executing but failing because BUILDKIT is turned off: https://github.com/pytorch/pytorch/actions/runs/11036043157/job/30653543264?pr=136544 Proposed Solution is to fix it in user_data . Please see: pytorch/test-infra#5712 I see docker builds are executed successfully here: https://github.com/pytorch/pytorch/actions/runs/11040149229/job/30667448668?pr=136544 Workaround timeout problem (reported in https://bugzilla.redhat.com/show_bug.cgi?id=1537564 ) by configuring number of open files per container to 1048576 Pull Request resolved: pytorch#136544 Approved by: https://github.com/ZainRizvi Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate these builds to linux 2023. We want to build and test the Docker images in CD.
Looks like we are hitting this issue: docker/buildx#379 when trying to build Docker on Amazon Linux 2023.
Conda Docker build is timing out. While Manywheel is executing but failing because BUILDKIT is turned off: https://github.com/pytorch/pytorch/actions/runs/11036043157/job/30653543264?pr=136544
Proposed Solution is to fix it in user_data . Please see: pytorch/test-infra#5712
I see docker builds are executed successfully here: https://github.com/pytorch/pytorch/actions/runs/11040149229/job/30667448668?pr=136544
Workaround timeout problem (reported in https://bugzilla.redhat.com/show_bug.cgi?id=1537564 ) by configuring number of open files per container to 1048576