KEMBAR78

[AILab][attempt2] Add TryExcept when decoding healthcheck port by wu0607 · Pull Request #136574 · pytorch/pytorch · GitHub

[AILab][attempt2] Add TryExcept when decoding healthcheck port #136574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

wu0607 wants to merge 1 commit into pytorch:main from wu0607:export-D63343041

Contributor

wu0607 commented Sep 24, 2024 •

edited by pytorch-bot bot

Loading

Summary:

Context

The first attempt has lint error in OSS https://hud.pytorch.org/pr/pytorch/pytorch/136438#30553902641
{F1886895223}

This Diff

Fix error message with try catch
Error Message:

  File "/packages/aps_models.examples.dlrm.lite/dlrm_train_app-inplace#link-tree/torch/distributed/elastic/agent/server/local_elastic_agent.py", line 224, in _setup_healthcheck
    port=int(healthcheck_port),
ValueError: invalid literal for int() with base 10: \'%port.thrift%\'

Test Plan:

arc lint

Reviewed By: felixsu2006

Differential Revision: D63343041

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

pytorch-bot bot commented Sep 24, 2024

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @wu0607, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

pytorch-bot bot added oncall: distributed release notes: distributed (torchelastic) labels

pytorch-bot bot commented Sep 24, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136574

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 3e0b252 with merge base 5233b5a ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / before-test / llm-retrieval (gh) (detected as infra flaky with no log or failing log classifier)

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-focal-py3.12-clang10 / test (dynamo, 2, 3, lf.linux.2xlarge) (gh) (trunk failure)
test_serialization.py::TestSerialization::test_skip_data_serialization_materialize_fake_False
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 2, 3, linux.2xlarge) (gh) (trunk failure)
test_serialization.py::TestSerialization::test_skip_data_serialization_materialize_fake_False

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D63343041

facebook-github-bot added the fb-exported label

atalman approved these changes

View reviewed changes

Contributor

atalman left a comment

lgtm given that lint is green

pytorch-bot bot added the ciflow/trunk label

wu0607 added a commit to wu0607/pytorch that referenced this pull request


          [AILab][attempt2] Add TryExcept when decoding healthcheck port (pytor…

68c5a4e

…ch#136574)

Summary:
Pull Request resolved: pytorch#136574

## Context
The first attempt has lint error in OSS https://hud.pytorch.org/pr/pytorch/pytorch/136438#30553902641
{F1886895223}
## This Diff
Fix error message with try catch
Error Message:
```
  File "/packages/aps_models.examples.dlrm.lite/dlrm_train_app-inplace#link-tree/torch/distributed/elastic/agent/server/local_elastic_agent.py", line 224, in _setup_healthcheck
    port=int(healthcheck_port),
ValueError: invalid literal for int() with base 10: \'%port.thrift%\'
```

Test Plan:
```
arc lint
```

Reviewed By: felixsu2006

Differential Revision: D63343041

wu0607 force-pushed the export-D63343041 branch from 3f0f264 to 68c5a4e Compare

September 24, 2024 21:51

Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D63343041

wu0607 force-pushed the export-D63343041 branch from 68c5a4e to 79278c2 Compare

September 24, 2024 21:57

Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D63343041

1 similar comment

Contributor

facebook-github-bot commented Sep 25, 2024

This pull request was exported from Phabricator. Differential Revision: D63343041

wu0607 force-pushed the export-D63343041 branch from 79278c2 to 0069281 Compare

September 25, 2024 00:00

wu0607 force-pushed the export-D63343041 branch from 0069281 to 0c9e005 Compare

September 25, 2024 00:09

wu0607 added a commit to wu0607/pytorch that referenced this pull request


          [AILab][attempt2] Add TryExcept when decoding healthcheck port (pytor…

0c9e005

…ch#136574)

Summary:
Pull Request resolved: pytorch#136574

## Context
The first attempt has lint error in OSS https://hud.pytorch.org/pr/pytorch/pytorch/136438#30553902641
{F1886895223}
## This Diff
Fix error message with try catch
Error Message:
```
  File "/packages/aps_models.examples.dlrm.lite/dlrm_train_app-inplace#link-tree/torch/distributed/elastic/agent/server/local_elastic_agent.py", line 224, in _setup_healthcheck
    port=int(healthcheck_port),
ValueError: invalid literal for int() with base 10: \'%port.thrift%\'
```

Test Plan:
```
arc lint
```

Reviewed By: felixsu2006

Differential Revision: D63343041

Contributor

facebook-github-bot commented Sep 25, 2024

This pull request was exported from Phabricator. Differential Revision: D63343041

wu0607 force-pushed the export-D63343041 branch from 0c9e005 to 938e7e2 Compare

September 25, 2024 00:54

Contributor

facebook-github-bot commented Sep 25, 2024

This pull request was exported from Phabricator. Differential Revision: D63343041


          [AILab][attempt2] Add TryExcept when decoding healthcheck port (pytor…

3e0b252

…ch#136574)

Summary:
Pull Request resolved: pytorch#136574

## Context
The first attempt has lint error in OSS https://hud.pytorch.org/pr/pytorch/pytorch/136438#30553902641
{F1886895223}
## This Diff
Fix error message with try catch
Error Message:
```
  File "/packages/aps_models.examples.dlrm.lite/dlrm_train_app-inplace#link-tree/torch/distributed/elastic/agent/server/local_elastic_agent.py", line 224, in _setup_healthcheck
    port=int(healthcheck_port),
ValueError: invalid literal for int() with base 10: \'%port.thrift%\'
```

Test Plan:
```
arc lint
```

Reviewed By: felixsu2006

Differential Revision: D63343041

Contributor

facebook-github-bot commented Sep 25, 2024

This pull request was exported from Phabricator. Differential Revision: D63343041

wu0607 force-pushed the export-D63343041 branch from 938e7e2 to 3e0b252 Compare

September 25, 2024 01:03

Contributor

facebook-github-bot commented Sep 25, 2024

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Sep 25, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

1cb265f

pytorchmergebot removed the merging label

BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request


          [AILab][attempt2] Add TryExcept when decoding healthcheck port (pytor…

e262fc3

…ch#136574)

Summary:
## Context
The first attempt has lint error in OSS https://hud.pytorch.org/pr/pytorch/pytorch/136438#30553902641
{F1886895223}
## This Diff
Fix error message with try catch
Error Message:
```
  File "/packages/aps_models.examples.dlrm.lite/dlrm_train_app-inplace#link-tree/torch/distributed/elastic/agent/server/local_elastic_agent.py", line 224, in _setup_healthcheck
    port=int(healthcheck_port),
ValueError: invalid literal for int() with base 10: \'%port.thrift%\'
```

Test Plan:
```
arc lint
```

Reviewed By: felixsu2006

Differential Revision: D63343041

Pull Request resolved: pytorch#136574
Approved by: https://github.com/atalman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged oncall: distributed release notes: distributed (torchelastic)