KEMBAR78
Tensorify compute on Python scalars by bobrenjc93 · Pull Request #136674 · pytorch/pytorch · GitHub
Skip to content

Tensorify compute on Python scalars #136674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Tensorify compute on Python scalars #136674

wants to merge 17 commits into from

Conversation

@bobrenjc93
Copy link
Contributor

@bobrenjc93 bobrenjc93 commented Sep 25, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Signed-off-by: Bob Ren <bobrenfb.com>

Comandeered from #130228 as I'm helping @ezyang w/ shipping dynamic float arguments in PT2. This starts with supporting torch.ops.aten.mul. I'll stack on top support for other operators in subsequent PRs to keep this scoped to the mechanics of the fx pass.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @rec

@bobrenjc93
Tensorify compute on Python scalars
0f68e27 
Signed-off-by: Bob Ren <bobrenfb.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136674

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d67d51a with merge base 81c8a8a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo module: inductor release notes: fx release notes category labels Sep 25, 2024
bobrenjc93 added a commit that referenced this pull request Sep 25, 2024
@bobrenjc93
Tensorify compute on Python scalars
c801681 
Signed-off-by: Bob Ren <bobrenfb.com>

ghstack-source-id: 898073a
Pull Request resolved: #136674
@bobrenjc93 bobrenjc93 marked this pull request as ready for review September 26, 2024 01:46
@bobrenjc93 bobrenjc93 requested a review from albanD as a code owner September 26, 2024 01:46
@bobrenjc93 bobrenjc93 requested a review from ezyang September 26, 2024 02:13
ezyang
ezyang reviewed Sep 26, 2024
View reviewed changes
ezyang
ezyang reviewed Sep 27, 2024
View reviewed changes
ezyang
ezyang reviewed Sep 27, 2024
View reviewed changes
ezyang
ezyang reviewed Sep 27, 2024
View reviewed changes
ezyang
ezyang reviewed Sep 27, 2024
View reviewed changes
ezyang
ezyang reviewed Sep 27, 2024
View reviewed changes
@ezyang
Copy link
Contributor

ezyang commented Sep 27, 2024

Nice work fixing the tests! After some slight refinements, the next step is scaleout!

@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 27, 2024
@bobrenjc93 bobrenjc93 mentioned this pull request Sep 27, 2024
Closed
@bobrenjc93
Update on "Tensorify compute on Python scalars"
9d3cbee 
Signed-off-by: Bob Ren <bobrenfb.com>

Comandeered from #130228 as I'm helping ezyang w/ shipping dynamic float arguments in PT2. This starts with supporting torch.ops.aten.mul. I'll stack on top support for other operators in subsequent PRs to keep this scoped to the mechanics of the fx pass.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec

[ghstack-poisoned]
@bobrenjc93
Update on "Tensorify compute on Python scalars"
2af2458 
Signed-off-by: Bob Ren <bobrenfb.com>

Comandeered from #130228 as I'm helping ezyang w/ shipping dynamic float arguments in PT2. This starts with supporting torch.ops.aten.mul. I'll stack on top support for other operators in subsequent PRs to keep this scoped to the mechanics of the fx pass.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec

[ghstack-poisoned]
@bobrenjc93
Update on "Tensorify compute on Python scalars"
41ec681 
Signed-off-by: Bob Ren <bobrenfb.com>

Comandeered from #130228 as I'm helping ezyang w/ shipping dynamic float arguments in PT2. This starts with supporting torch.ops.aten.mul. I'll stack on top support for other operators in subsequent PRs to keep this scoped to the mechanics of the fx pass.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec

[ghstack-poisoned]
@bobrenjc93
Update on "Tensorify compute on Python scalars"
f998d00 
Signed-off-by: Bob Ren <bobrenfb.com>

Comandeered from #130228 as I'm helping ezyang w/ shipping dynamic float arguments in PT2. This starts with supporting torch.ops.aten.mul. I'll stack on top support for other operators in subsequent PRs to keep this scoped to the mechanics of the fx pass.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec

[ghstack-poisoned]
bobrenjc93
bobrenjc93 commented Sep 29, 2024
View reviewed changes
@bobrenjc93
Update on "Tensorify compute on Python scalars"
8362746 
Signed-off-by: Bob Ren <bobrenfb.com>

Comandeered from #130228 as I'm helping ezyang w/ shipping dynamic float arguments in PT2. This starts with supporting torch.ops.aten.mul. I'll stack on top support for other operators in subsequent PRs to keep this scoped to the mechanics of the fx pass.

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang rec

[ghstack-poisoned]
bobrenjc93
bobrenjc93 commented Oct 8, 2024
View reviewed changes
ezyang
ezyang reviewed Oct 9, 2024
View reviewed changes
ezyang
ezyang reviewed Oct 9, 2024
View reviewed changes
ezyang
ezyang reviewed Oct 9, 2024
View reviewed changes
ezyang
ezyang reviewed Oct 9, 2024
View reviewed changes
ezyang
ezyang reviewed Oct 9, 2024
View reviewed changes
ezyang
ezyang approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

This was referenced Oct 9, 2024
Closed
Closed
@bobrenjc93
Copy link
Contributor Author

Comments address in #137588

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced Oct 9, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 9, 2024
@bobrenjc93 @pytorchmergebot
Use MetaProxy more pervasively (#137588)
9b01d17 
Pull Request resolved: #137588
Approved by: https://github.com/ezyang
ghstack dependencies: #136674
@bobrenjc93 bobrenjc93 mentioned this pull request Oct 11, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 12, 2024
@bobrenjc93 @pytorchmergebot
Add support for add in tensorify_python_scalars fx pass (#137620)
0430e72 
Pull Request resolved: #137620
Approved by: https://github.com/ezyang
ghstack dependencies: #136674, #137588
@github-actions github-actions bot deleted the gh/bobrenjc93/27/head branch November 9, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laithsakka laithsakka laithsakka left review comments

@bdhirsh bdhirsh bdhirsh left review comments

@ezyang ezyang ezyang approved these changes

@albanD albanD albanD left review comments

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo module: inductor release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bobrenjc93 @ezyang @pytorchmergebot @albanD @laithsakka @bdhirsh