KEMBAR78
Add diagonal_copy to torch/_decomp/__init__.py by LJ-underdog · Pull Request #136730 · pytorch/pytorch · GitHub
Skip to content

Add diagonal_copy to torch/_decomp/__init__.py #136730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Add diagonal_copy to torch/_decomp/__init__.py #136730

wants to merge 7 commits into from

Conversation

@LJ-underdog
Copy link
Contributor

Fixes #117349

@LJ-underdog
Add diagonal_copy to torch/_decomp/__init__.py
9b65892 
Signed-off-by: intellinjun <jun.lin@intel.com>
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136730

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3766723 with merge base 38d9924 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@LJ-underdog
Add diagonal_copy to torch/_decomp/__init__.py
7c46408 
Signed-off-by: intellinjun <jun.lin@intel.com>
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024

Didn't find following labels among repository labels: topic: release notes decomp`

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024

Didn't find following labels among repository labels: topic: release notes`

@LJ-underdog
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 26, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024

Didn't find following labels among repository labels: topic: release notes:fx

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024

Didn't find following labels among repository labels: release notes:fx

@LJ-underdog
update test/expect/HasDecompTest.test_aten_core_operators.expect
ea0a7fc 
Signed-off-by: intellinjun <jun.lin@intel.com>
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024

Didn't find following labels among repository labels: topic: traged

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024

Didn't find following labels among repository labels: topic: traiged

@LJ-underdog
Copy link
Contributor Author

@pytorchbot label "topic: triaged"

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024

Didn't find following labels among repository labels: topic: triaged

@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 27, 2024
@LJ-underdog
Copy link
Contributor Author

@cpuhrsch It looks like we need to update the expert file HasDecompTest.test_aten_core_operators.expect which is used for testing.

@LJ-underdog
Copy link
Contributor Author

@cpuhrsch It looks like we need to update the expert file HasDecompTest.test_aten_core_operators.expect which is used for testing.

But I don't have permission to change this file

@LJ-underdog
Copy link
Contributor Author

@angelayi @masnesral

@masnesral
Copy link
Contributor

But I don't have permission to change this file

Sorry - What does it mean? You can't add it to this PR?

masnesral
masnesral requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@masnesral masnesral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I shouldn't accept until we have the tests passing.

@LJ-underdog
Copy link
Contributor Author

I guess I shouldn't accept until we have the tests passing.

I'll fix those tests.

@LJ-underdog
Copy link
Contributor Author

I guess I shouldn't accept until we have the tests passing.

The problem with test has been fixed

@masnesral masnesral added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2024
@masnesral
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

aostrowski-hbn pushed a commit to HabanaAI/pytorch-fork that referenced this pull request Jan 7, 2025
@aostrowski-hbn
Add diagonal_copy to torch/_decomp/__init__.py (pytorch#136730)
dc82665 
Fixes pytorch#117349

Pull Request resolved: pytorch#136730
Approved by: https://github.com/masnesral

Change-Id: Ida407dd11a6a489f73d18d964753a143b26384a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masnesral masnesral masnesral approved these changes

@angelayi angelayi Awaiting requested review from angelayi

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The diag should be dispatched to core IR for matrix input

5 participants

@LJ-underdog @masnesral @pytorchmergebot @cpuhrsch @pytorchbot