[EZ][BE] Add `torch.complex` to MPS_DTYPES #136755

malfet · 2024-09-26T13:59:15Z

Stack from ghstack (oldest at bottom):

As minimal supported OS has been rasied to MacOS 13, some basic complex operations should be supported, and the rest could be xfailed

As minimal supported OS has been rasied to MacOS 13, complex datatypes should be supported [ghstack-poisoned]

pytorch-bot · 2024-09-26T13:59:19Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136755

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit b81da02 with merge base 3c542ce ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

Mac MPS / macos-py3-arm64-mps / test (mps, 1, 1, macos-m2-15) (gh) (detected as infra flaky with no runner)
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, lf.linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
inductor/test_flex_decoding.py::TestFlexDecoding::test_non_sparse_mulitple_block_size

This comment was automatically generated by Dr. CI and updates every 15 minutes.

As minimal supported OS has been rasied to MacOS 13, complex datatypes should be supported [ghstack-poisoned]

As minimal supported OS has been rasied to MacOS 13, some basic complex operations should be supported, and the rest could be `xfailed` [ghstack-poisoned]

As minimal supported OS has been rasied to MacOS 13, complex datatypes should be supported ghstack-source-id: 5abfbe2 Pull Request resolved: #136755

malfet · 2024-09-27T04:59:41Z

@pytorchbot merge -f *MPS tests are green"

pytorch-bot · 2024-09-27T04:59:43Z

❌ 🤖 pytorchbot command failed:

Got EOF while in a quoted string```
Try `@pytorchbot --help` for more info.

malfet · 2024-09-27T04:59:55Z

@pytorchbot merge -f "MPS tests are green"

pytorchmergebot · 2024-09-27T05:01:32Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

`norm` and `masked.normalize` still have to stay in the list Pull Request resolved: #136821 Approved by: https://github.com/Skylion007 ghstack dependencies: #136754, #136755

This was a stupid cast error that caused MPSGraph to crash with the following exception ``` (mpsFileLoc): /AppleInternal/Library/BuildRoots/e0873e53-5185-11ef-9a51-9ab6d782fe32/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphUtilities.mm:233:0: error: 'mps.multiply' op requires the same element type for all operands and results (mpsFileLoc): /AppleInternal/Library/BuildRoots/e0873e53-5185-11ef-9a51-9ab6d782fe32/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphUtilities.mm:233:0: note: see current operation: %3 = "mps.multiply"(%2, %arg1) : (tensor<1x3x9x9xf16>, tensor<1xf32>) -> tensor<*xf32> (mpsFileLoc): /AppleInternal/Library/BuildRoots/e0873e53-5185-11ef-9a51-9ab6d782fe32/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphUtilities.mm:233:0: error: 'mps.multiply' op requires the same element type for all operands and results (mpsFileLoc): /AppleInternal/Library/BuildRoots/e0873e53-5185-11ef-9a51-9ab6d782fe32/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphUtilities.mm:233:0: note: see current operation: %3 = "mps.multiply"(%2, %arg1) : (tensor<1x3x9x9xf16>, tensor<1xf32>) -> tensor<*xf32> /AppleInternal/Library/BuildRoots/e0873e53-5185-11ef-9a51-9ab6d782fe32/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphExecutable.mm:953: failed assertion `original module failed verification' ``` Pull Request resolved: #136822 Approved by: https://github.com/Skylion007 ghstack dependencies: #136754, #136755, #136821

Before that attempt to run something like ``` % python -c "import torch;dev,dt='mps',torch.int; print(torch.normal(mean=torch.arange(1., 11., device=dev, dtype=dt), std=torch.arange(10, 0, -1, device=dev, dtype=dt)))" ``` Resulted in hard error ``` (mpsFileLoc): /AppleInternal/Library/BuildRoots/e0873e53-5185-11ef-9a51-9ab6d782fe32/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphUtilities.mm:233:0: error: 'mps.multiply' op requires the same element type for all operands and results (mpsFileLoc): /AppleInternal/Library/BuildRoots/e0873e53-5185-11ef-9a51-9ab6d782fe32/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphUtilities.mm:233:0: note: see current operation: %5 = "mps.multiply"(%2, %arg1) : (tensor<10xf32>, tensor<10xsi32>) -> tensor<*xf32> (mpsFileLoc): /AppleInternal/Library/BuildRoots/e0873e53-5185-11ef-9a51-9ab6d782fe32/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphUtilities.mm:233:0: error: 'mps.multiply' op requires the same element type for all operands and results (mpsFileLoc): /AppleInternal/Library/BuildRoots/e0873e53-5185-11ef-9a51-9ab6d782fe32/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphUtilities.mm:233:0: note: see current operation: %5 = "mps.multiply"(%2, %arg1) : (tensor<10xf32>, tensor<10xsi32>) -> tensor<*xf32> /AppleInternal/Library/BuildRoots/e0873e53-5185-11ef-9a51-9ab6d782fe32/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphExecutable.mm:953: failed assertion `original module failed verification' ``` After the change, it raises a nice type error Pull Request resolved: #136863 Approved by: https://github.com/Skylion007 ghstack dependencies: #136754, #136755, #136821, #136822

[EZ][BE] Add torch.complex to MPS_DTYPES

395f5ad

As minimal supported OS has been rasied to MacOS 13, complex datatypes should be supported [ghstack-poisoned]

malfet requested a review from kulinseth as a code owner September 26, 2024 13:59

malfet mentioned this pull request Sep 26, 2024

[EZ][MPS] Extend arange to bfloat16 #136754

Closed

pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) topic: not user facing topic category labels Sep 26, 2024

Skylion007 approved these changes Sep 26, 2024

View reviewed changes

Update on "[EZ][BE] Add torch.complex to MPS_DTYPES"

7f36214

As minimal supported OS has been rasied to MacOS 13, complex datatypes should be supported [ghstack-poisoned]

Update on "[EZ][BE] Add torch.complex to MPS_DTYPES"

ece1400

As minimal supported OS has been rasied to MacOS 13, some basic complex operations should be supported, and the rest could be `xfailed` [ghstack-poisoned]

Update on "[EZ][BE] Add torch.complex to MPS_DTYPES"

b81da02

As minimal supported OS has been rasied to MacOS 13, some basic complex operations should be supported, and the rest could be `xfailed` [ghstack-poisoned]

malfet added a commit that referenced this pull request Sep 27, 2024

[EZ][BE] Add torch.complex to MPS_DTYPES

3d59186

As minimal supported OS has been rasied to MacOS 13, complex datatypes should be supported ghstack-source-id: 5abfbe2 Pull Request resolved: #136755

This was referenced Sep 27, 2024

[BE][MPS] Delete MacOS12 low-precision ops #136821

Closed

[MPS] Fix AvgPool2d for float16 #136822

Closed

pytorchmergebot added the merging label Sep 27, 2024

pytorchmergebot closed this in 69bd13d Sep 27, 2024

pytorchmergebot added Merged and removed merging labels Sep 27, 2024

malfet mentioned this pull request Sep 27, 2024

[MPS] Error checking/bf16 support for torch.normal #136863

Closed

github-actions bot deleted the gh/malfet/16/head branch November 3, 2024 02:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[EZ][BE] Add `torch.complex` to MPS_DTYPES #136755

[EZ][BE] Add `torch.complex` to MPS_DTYPES #136755

Uh oh!

malfet commented Sep 26, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Sep 26, 2024 •

edited

Loading

Uh oh!

malfet commented Sep 27, 2024

Uh oh!

pytorch-bot bot commented Sep 27, 2024

Uh oh!

malfet commented Sep 27, 2024

Uh oh!

pytorchmergebot commented Sep 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[EZ][BE] Add torch.complex to MPS_DTYPES #136755

[EZ][BE] Add torch.complex to MPS_DTYPES #136755

Uh oh!

Conversation

malfet commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136755

✅ You can merge normally! (2 Unrelated Failures)

Uh oh!

malfet commented Sep 27, 2024

Uh oh!

pytorch-bot bot commented Sep 27, 2024

Uh oh!

malfet commented Sep 27, 2024

Uh oh!

pytorchmergebot commented Sep 27, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[EZ][BE] Add `torch.complex` to MPS_DTYPES #136755

[EZ][BE] Add `torch.complex` to MPS_DTYPES #136755

malfet commented Sep 26, 2024 •

edited

Loading

pytorch-bot bot commented Sep 26, 2024 •

edited

Loading