Init threadpool with user defined num_threads before default #136793
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136793
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit c6b6e0c with merge base a259fbf ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
approved these changes
Sep 26, 2024
Fixes #134714 (or attempts to, idk how to test yet) [ghstack-poisoned]
albanD
approved these changes
Sep 27, 2024
|
@pytorchbot merge Thanks @albanD! |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -c ghfirst -m "Caused internal Oculus crash, and internal force landed a diff without exporting to GH =.=" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Sep 30, 2024
…136793)" This reverts commit adbcaee. Reverted #136793 on behalf of https://github.com/janeyx99 due to Caused internal Oculus crash, and internal force landed a diff without exporting to GH =.= ([comment](#136793 (comment)))
|
@janeyx99 your PR has been successfully reverted. |
Fixes #134714 (or attempts to, idk how to test yet) For posterity, how one can test: 1. make sure you have USE_PTHREADPOOL=1 or pull a packaged binary 2. run gdb --args python, with `r` to enter, `Ctrl-C` to pause, and `c` to get back into Python 3. import torch 4. torch.set_num_threads(1), make sure this does not trigger any additional threads getting created. [ghstack-poisoned]
|
Closing in favor of #137051 |
AnantGulati
pushed a commit
to AnantGulati/pytorch
that referenced
this pull request
Oct 2, 2024
…ytorch#136793)" This reverts commit adbcaee. Reverted pytorch#136793 on behalf of https://github.com/janeyx99 due to Caused internal Oculus crash, and internal force landed a diff without exporting to GH =.= ([comment](pytorch#136793 (comment)))
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 2, 2024
…fault (#137051) Very similar to #136793, but adds back `pool->set_thread_count` call as it is still necessary (I am guessing due to the mutex) Fixes #ISSUE_NUMBER Pull Request resolved: #137051 Approved by: https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134714 (or attempts to, idk how to test yet)
For posterity, how one can test:
rto enter,Ctrl-Cto pause, andcto get back into PythonStack from ghstack (oldest at bottom):