KEMBAR78
Get rid of quadratic tests to has_same_metadata by ezyang · Pull Request #136857 · pytorch/pytorch · GitHub
Skip to content

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Sep 27, 2024

Stack from ghstack (oldest at bottom):

Fixes #136852

Signed-off-by: Edward Z. Yang ezyang@meta.com

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 27, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136857

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 346d0f2 with merge base c010c60 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Sep 27, 2024
Fixes #136852

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: b47f2b1
Pull Request resolved: #136857
@pytorch-bot pytorch-bot bot added ciflow/inductor release notes: fx release notes category labels Sep 27, 2024
@ezyang ezyang requested review from IvanKobzarev and isuruf and removed request for SherlockNoMad, albanD, antoniojkim and miladm September 27, 2024 14:24
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Sep 30, 2024
Fixes #136852

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 5d3c282
Pull Request resolved: #136857
@ezyang
Copy link
Contributor Author

ezyang commented Sep 30, 2024

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 30, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 5, 5, lf.linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Oct 8, 2024

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/ezyang/2943/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging torch/fx/experimental/symbolic_shapes.py
CONFLICT (content): Merge conflict in torch/fx/experimental/symbolic_shapes.py
error: could not apply 8ef359abd4... Get rid of quadratic tests to has_same_metadata
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Could not apply 8ef359abd4... Get rid of quadratic tests to has_same_metadata

Raised by https://github.com/pytorch/pytorch/actions/runs/11237649327

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Oct 8, 2024
Fixes #136852

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: ebdc982
Pull Request resolved: #136857
@ezyang
Copy link
Contributor Author

ezyang commented Oct 8, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@laithsakka
Copy link
Contributor

this has 20% win on one benchmark

{
"update_hint_regression": -19.439237957833
}

@github-actions github-actions bot deleted the gh/ezyang/2943/head branch November 8, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants