[reland][Elastic] Skip store barrier and store get in host assign #136865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As title this is to reland #136579 as it broke some OSS CI Differential Revision: [D63542918](https://our.internmc.facebook.com/intern/diff/D63542918/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136865
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (7 Unrelated Failures)As of commit 8561f56 with merge base c2637a7 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
|
This pull request was exported from Phabricator. Differential Revision: D63542918 |
… assign" As title this is to reland #136579 as it broke some OSS CI Differential Revision: [D63542918](https://our.internmc.facebook.com/intern/diff/D63542918/) cc XilunWu H-Huang awgu kwen2501 wanchaol fegin wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D63542918 |
… assign" As title this is to reland #136579 as it broke some OSS CI Differential Revision: [D63542918](https://our.internmc.facebook.com/intern/diff/D63542918/) cc XilunWu H-Huang awgu kwen2501 wanchaol fegin wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
fduwjj
added a commit
that referenced
this pull request
Sep 27, 2024
Pull Request resolved: #136865 As title this is to reland #136579 as it broke some OSS CI ghstack-source-id: 245131066 Differential Revision: [D63542918](https://our.internmc.facebook.com/intern/diff/D63542918/)
|
This pull request was exported from Phabricator. Differential Revision: D63542918 |
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 29, 2024
…CAL for unit test (#136916) as title, this is an easy fix for unit test. Differential Revision: [D63577774](https://our.internmc.facebook.com/intern/diff/D63577774/) Pull Request resolved: #136916 Approved by: https://github.com/wz337 ghstack dependencies: #136865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As title this is to reland #136579 as it broke some OSS CI
Differential Revision: D63542918
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @wz337 @wconstab @d4l3k @c-p-i-o