KEMBAR78
[inductor] Enable coordinate descent tuning with max-autotune by jansel · Pull Request #136867 · pytorch/pytorch · GitHub
Skip to content

Conversation

@jansel
Copy link
Contributor

@jansel jansel commented Sep 27, 2024

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 27, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136867

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a9b04d0 with merge base 22e19bd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
jansel added a commit that referenced this pull request Sep 27, 2024
[ghstack-poisoned]
jansel added a commit that referenced this pull request Sep 28, 2024
@jansel
Copy link
Contributor Author

jansel commented Oct 4, 2024

@pytorchbot rebase

@jansel jansel marked this pull request as ready for review October 4, 2024 22:39
@jansel jansel requested a review from eellison October 4, 2024 22:39
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/jansel/405/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/136867)

pytorchmergebot pushed a commit that referenced this pull request Oct 4, 2024
@jansel jansel requested a review from Chillee October 7, 2024 16:27
Copy link
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for it :P

I'd worry about folks complaining about compile-time regressions internally though - I'm sure you're aware.

Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a good opportunity to add opt_level as a kwarg ? We just had reports internally for a model that doubled compilation time with coordinate descent tuning.

I think we could also roll this out by default in max-autotune by only targeting the relatively more expensive kernels.

@jansel
Copy link
Contributor Author

jansel commented Oct 10, 2024

In my testing the added compile time was small compared to matmuls. I think we should embrace the "max" in "max-autotune".

@jansel
Copy link
Contributor Author

jansel commented Oct 10, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 10, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/jansel/405/head branch November 10, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants