Fix prefix store seg fault #136872
Fix prefix store seg fault #136872
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136872
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit c1784f9 with merge base 156ca01 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
| prefix (str): The prefix string that is prepended to each key before being inserted into the store. | ||
| store (torch.distributed.store): A store object that forms the underlying key-value store. | ||
| )") | ||
| .def(py::init<const std::string&, c10::intrusive_ptr<::c10d::Store>>()) |
There was a problem hiding this comment.
The previous behavior looks very suspicious that makes me even wonder if there is a specific purpose. (lol)
There was a problem hiding this comment.
im not sure either hahaha, lets see from the tests. Though there were very few PrefixStore tests from what i can tell
fixes #136723 Do not allow `None` to be passed into `PrefixStore` cc XilunWu awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
fixes #136723 Do not allow `None` to be passed into `PrefixStore` cc XilunWu awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
fixes #136723 Do not allow `None` to be passed into `PrefixStore` cc XilunWu awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
fixes #136723 Do not allow `None` to be passed into `PrefixStore` cc XilunWu awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
fixes #136723 Do not allow `None` to be passed into `PrefixStore` cc XilunWu awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
fixes #136723 Do not allow `None` to be passed into `PrefixStore` cc XilunWu awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 2 checks: Lint / Test Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
fixes pytorch#136723 Do not allow `None` to be passed into `PrefixStore` Pull Request resolved: pytorch#136872 Approved by: https://github.com/kwen2501
3 participants
Stack from ghstack (oldest at bottom):
fixes #136723
Do not allow
Noneto be passed intoPrefixStorecc @XilunWu @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o