KEMBAR78
Continue on error for pytorch autolint by PaliC · Pull Request #137104 · pytorch/pytorch · GitHub
Skip to content

Continue on error for pytorch autolint #137104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Continue on error for pytorch autolint #137104

wants to merge 1 commit into from

Conversation

@PaliC
Copy link
Contributor

@PaliC PaliC commented Oct 1, 2024

Fixes #ISSUE_NUMBER

@PaliC PaliC requested a review from a team as a code owner October 1, 2024 17:38
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 1, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137104

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit dd0aa20 with merge base b1b6816 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

huydhn
huydhn approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PaliC
Copy link
Contributor Author

PaliC commented Oct 1, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 1, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

atalman
atalman approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PaliC
Copy link
Contributor Author

PaliC commented Oct 1, 2024

@pytorchbot merge -f "tests pass and this should unblock some users"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@PaliC @AnantGulati
Continue on error for pytorch autolint (pytorch#137104)
b18a850 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#137104
Approved by: https://github.com/huydhn, https://github.com/atalman
@github-actions github-actions bot deleted the PaliC-patch-1 branch November 6, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PaliC @pytorchmergebot @huydhn @atalman