Fix to() on non-contiguous NJTs #137124
Closed
Fix to() on non-contiguous NJTs #137124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137124
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit cb7ea56 with merge base 0ccd39a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 1, 2024
jbschlosser
added
topic: improvements
Called out via torchrec integration: `lengths` is not handled properly.
Future work (not related to non-contiguous NJTs): debug torch.compile problem; new nested int is allocated only for compile.
```python
import torch
def f(nt):
return nt.to(device="cpu")
compiled_f = torch.compile(f)
nt = torch.nested.nested_tensor([
torch.randn(2, 5),
torch.randn(3, 5),
torch.randn(4, 5),
], layout=torch.jagged, device="cuda")
out = f(nt)
out_compile = compiled_f(nt)
print(out.shape, out_compile.shape)
```
```
AssertionError: The values for attribute 'shape' do not match: torch.Size([7, j2]) != torch.Size([7, j1])
```
[ghstack-poisoned]
Called out via torchrec integration: `lengths` is not handled properly.
Future work (not related to non-contiguous NJTs): debug torch.compile problem; new nested int is allocated only for compile.
```python
import torch
def f(nt):
return nt.to(device="cpu")
compiled_f = torch.compile(f)
nt = torch.nested.nested_tensor([
torch.randn(2, 5),
torch.randn(3, 5),
torch.randn(4, 5),
], layout=torch.jagged, device="cuda")
out = f(nt)
out_compile = compiled_f(nt)
print(out.shape, out_compile.shape)
```
```
AssertionError: The values for attribute 'shape' do not match: torch.Size([7, j2]) != torch.Size([7, j1])
```
[ghstack-poisoned]
Called out via torchrec integration: `lengths` is not handled properly.
Future work (not related to non-contiguous NJTs): debug torch.compile problem; new nested int is allocated only for compile.
```python
import torch
def f(nt):
return nt.to(device="cpu")
compiled_f = torch.compile(f)
nt = torch.nested.nested_tensor([
torch.randn(2, 5),
torch.randn(3, 5),
torch.randn(4, 5),
], layout=torch.jagged, device="cuda")
out = f(nt)
out_compile = compiled_f(nt)
print(out.shape, out_compile.shape)
```
```
AssertionError: The values for attribute 'shape' do not match: torch.Size([7, j2]) != torch.Size([7, j1])
```
[ghstack-poisoned]
Called out via torchrec integration: `lengths` is not handled properly.
Future work (not related to non-contiguous NJTs): debug torch.compile problem; new nested int is allocated only for compile.
```python
import torch
def f(nt):
return nt.to(device="cpu")
compiled_f = torch.compile(f)
nt = torch.nested.nested_tensor([
torch.randn(2, 5),
torch.randn(3, 5),
torch.randn(4, 5),
], layout=torch.jagged, device="cuda")
out = f(nt)
out_compile = compiled_f(nt)
print(out.shape, out_compile.shape)
```
```
AssertionError: The values for attribute 'shape' do not match: torch.Size([7, j2]) != torch.Size([7, j1])
```
[ghstack-poisoned]
Called out via torchrec integration: `lengths` is not handled properly.
Future work (not related to non-contiguous NJTs): debug torch.compile problem; new nested int is allocated only for compile.
```python
import torch
def f(nt):
return nt.to(device="cpu")
compiled_f = torch.compile(f)
nt = torch.nested.nested_tensor([
torch.randn(2, 5),
torch.randn(3, 5),
torch.randn(4, 5),
], layout=torch.jagged, device="cuda")
out = f(nt)
out_compile = compiled_f(nt)
print(out.shape, out_compile.shape)
```
```
AssertionError: The values for attribute 'shape' do not match: torch.Size([7, j2]) != torch.Size([7, j1])
```
[ghstack-poisoned]
Called out via torchrec integration: `lengths` is not handled properly.
Future work (not related to non-contiguous NJTs): debug torch.compile problem; new nested int is allocated only for compile.
```python
import torch
def f(nt):
return nt.to(device="cpu")
compiled_f = torch.compile(f)
nt = torch.nested.nested_tensor([
torch.randn(2, 5),
torch.randn(3, 5),
torch.randn(4, 5),
], layout=torch.jagged, device="cuda")
out = f(nt)
out_compile = compiled_f(nt)
print(out.shape, out_compile.shape)
```
```
AssertionError: The values for attribute 'shape' do not match: torch.Size([7, j2]) != torch.Size([7, j1])
```
[ghstack-poisoned]
Called out via torchrec integration: `lengths` is not handled properly.
Future work (not related to non-contiguous NJTs): debug torch.compile problem; new nested int is allocated only for compile.
```python
import torch
def f(nt):
return nt.to(device="cpu")
compiled_f = torch.compile(f)
nt = torch.nested.nested_tensor([
torch.randn(2, 5),
torch.randn(3, 5),
torch.randn(4, 5),
], layout=torch.jagged, device="cuda")
out = f(nt)
out_compile = compiled_f(nt)
print(out.shape, out_compile.shape)
```
```
AssertionError: The values for attribute 'shape' do not match: torch.Size([7, j2]) != torch.Size([7, j1])
```
[ghstack-poisoned]
Called out via torchrec integration: `lengths` is not handled properly.
Future work (not related to non-contiguous NJTs): debug torch.compile problem; new nested int is allocated only for compile.
```python
import torch
def f(nt):
return nt.to(device="cpu")
compiled_f = torch.compile(f)
nt = torch.nested.nested_tensor([
torch.randn(2, 5),
torch.randn(3, 5),
torch.randn(4, 5),
], layout=torch.jagged, device="cuda")
out = f(nt)
out_compile = compiled_f(nt)
print(out.shape, out_compile.shape)
```
```
AssertionError: The values for attribute 'shape' do not match: torch.Size([7, j2]) != torch.Size([7, j1])
```
[ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_4-test / test, linux-binary-manywheel / manywheel-py3_9-cuda12_1-test / test Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: linux-binary-manywheel / manywheel-py3_9-cuda12_4-test / test, linux-binary-manywheel / manywheel-py3_9-cuda12_1-test / test, linux-binary-manywheel / manywheel-py3_9-cuda11_8-test / test Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Called out via torchrec integration:
lengthsis not handled properly.Future work (not related to non-contiguous NJTs): #137275