KEMBAR78
[CI] Remove nanogpt from perf smoke test by desertfire · Pull Request #137176 · pytorch/pytorch · GitHub
Skip to content

[CI] Remove nanogpt from perf smoke test #137176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[CI] Remove nanogpt from perf smoke test #137176

wants to merge 1 commit into from

Conversation

@desertfire
Copy link
Contributor

@desertfire desertfire commented Oct 2, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary: nanogpt's performance is not stable. Remove it from the perf smoke test. We may want to use another test instead.

@desertfire
[CI] Remove nanogpt from perf smoke test
1c14247 
Summary: nanogpt's performance is not stable. Remove it from the perf smoke test. We may want to use another test instead.

[ghstack-poisoned]
@desertfire desertfire requested a review from a team as a code owner October 2, 2024 14:21
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137176

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 1c14247 with merge base 5c2c3ca (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 2, 2024
Closed
Closed
Closed
@desertfire
Copy link
Contributor Author

@pytorchbot merge -f "inductor_torchbench_smoketest_perf has passed"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@eellison
Copy link
Contributor

eellison commented Oct 3, 2024

was it unstable, or was there just a regression ? #137248

@desertfire
Copy link
Contributor Author

was it unstable, or was there just a regression ? #137248

It was unstable, but only seems like a recent issue,
Screenshot 2024-10-03 at 9 37 30 PM

@github-actions github-actions bot deleted the gh/desertfire/483/head branch November 6, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

@shunting314 shunting314 Awaiting requested review from shunting314

Assignees

No one assigned

Labels

ciflow/inductor Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@desertfire @pytorchmergebot @eellison