KEMBAR78
Fix serialization for torch.uint16, torch.uint32, torch.uint64 by mikaylagawarecki · Pull Request #137184 · pytorch/pytorch · GitHub
Skip to content

Fix serialization for torch.uint16, torch.uint32, torch.uint64 #137184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix serialization for torch.uint16, torch.uint32, torch.uint64 #137184

wants to merge 3 commits into from

Conversation

@mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Oct 2, 2024 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137184

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 977fa2e with merge base 862029a (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mikaylagawarecki mikaylagawarecki added release notes: python_frontend python frontend release notes category topic: bug fixes topic category labels Oct 2, 2024
mikaylagawarecki added a commit that referenced this pull request Oct 2, 2024
@mikaylagawarecki
Fix serialization for torch.uint16, torch.uint32, torch.uint64
bac6adc 
ghstack-source-id: c1bb486
Pull Request resolved: #137184
@mikaylagawarecki mikaylagawarecki marked this pull request as ready for review October 2, 2024 20:22
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2024

This PR needs to be approved by an authorized maintainer before merge.

albanD
albanD approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on the condition. but sgtm otherwise

mikaylagawarecki added a commit that referenced this pull request Oct 2, 2024
@mikaylagawarecki
Fix serialization for torch.uint16, torch.uint32, torch.uint64
5e2e116 
ghstack-source-id: 307e50a
Pull Request resolved: #137184
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 2, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@Skylion007
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mikaylagawarecki mikaylagawarecki mentioned this pull request Oct 7, 2024
Closed
@github-actions github-actions bot deleted the gh/mikaylagawarecki/265/head branch November 6, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: python_frontend python frontend release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikaylagawarecki @pytorchmergebot @Skylion007 @albanD