KEMBAR78
[FlexAttention] Adjust BlockMask if reusing the one created at larger seqlen by yanboliang · Pull Request #137255 · pytorch/pytorch · GitHub
Skip to content

[FlexAttention] Adjust BlockMask if reusing the one created at larger seqlen #137255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[FlexAttention] Adjust BlockMask if reusing the one created at larger seqlen #137255

wants to merge 4 commits into from

Conversation

@yanboliang
Copy link
Contributor

@yanboliang yanboliang commented Oct 3, 2024 •
edited
Loading

@yanboliang
Update
936d26c 
[ghstack-poisoned]
yanboliang added a commit that referenced this pull request Oct 3, 2024
@yanboliang
[FlexAttention] Adjust BlockMask if reusing the one created at larger…
274c743 
… seqlen

ghstack-source-id: a700f30
Pull Request resolved: #137255
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137255

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 24550d0 with merge base a408cfc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@yanboliang yanboliang added the topic: not user facing topic category label Oct 3, 2024
@leijurv
Copy link

leijurv commented Oct 3, 2024

Related to #136232

@yanboliang
Copy link
Contributor Author

Yea, this is exactly going to fix #136232

@yanboliang
Update
4604b42 
[ghstack-poisoned]
@yanboliang
Update
a44c02b 
[ghstack-poisoned]
Chillee
Chillee approved these changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@yanboliang
Update
24550d0 
[ghstack-poisoned]
yanboliang added a commit that referenced this pull request Oct 5, 2024
@yanboliang
[FlexAttention] Adjust BlockMask if reusing the one created at larger…
1896b0f 
… seqlen

ghstack-source-id: 929e827
Pull Request resolved: #137255
@yanboliang yanboliang added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 5, 2024
@yanboliang
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@yanboliang yanboliang deleted the gh/yanboliang/44/head branch October 5, 2024 19:27
@jbschlosser jbschlosser mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chillee Chillee Chillee approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanboliang @leijurv @pytorchmergebot @Chillee