KEMBAR78
Revert runtime numeric check in inductor due to increased compilation time by mengluy0125 · Pull Request #137324 · pytorch/pytorch · GitHub
Skip to content

Revert runtime numeric check in inductor due to increased compilation time #137324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert runtime numeric check in inductor due to increased compilation time #137324

wants to merge 1 commit into from

Conversation

@mengluy0125
Copy link
Contributor

@mengluy0125 mengluy0125 commented Oct 4, 2024 •
edited by pytorch-bot bot
Loading

Summary:
This diff reverts D63438718
Cause latency regression on multiple models

Test Plan: NA

Differential Revision: D63872515

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137324

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4f667a8 with merge base 711dacf (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63872515

@mengluy0125 mengluy0125 changed the title Revert D63438718 Revert runtime numeric check in inductor due to increased compilation time Oct 4, 2024
mengluy0125 added a commit to mengluy0125/pytorch that referenced this pull request Oct 4, 2024
@mengluy0125 @facebook-github-bot
Revert runtime numeric check in inductor due to increased compilation…
cf865c1 
… time (pytorch#137324)

Summary:

This diff reverts D63438718
Cause latency regression on multiple models

Test Plan: NA

Differential Revision: D63872515
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63872515

xuzhao9
xuzhao9 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 4, 2024
@mengluy0125 @facebook-github-bot
Revert runtime numeric check in inductor due to increased compilation…
4f667a8 
… time (pytorch#137324)

Summary:

This diff reverts D63438718
Cause latency regression on multiple models

Test Plan: NA

Reviewed By: xuzhao9

Differential Revision: D63872515
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63872515

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xuzhao9 xuzhao9 xuzhao9 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor release notes: inductor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mengluy0125 @facebook-github-bot @pytorchmergebot @xuzhao9